[webview_flutter] Send history events #2379

wwwdata · 2019-12-09T11:45:40Z

Description

Send URL change events when the user navigates in the Browser. This also works for JavaScript Navigation that does not actually make any request and therefore would not trigger page load or finish events.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

ened · 2019-12-10T09:19:39Z

hi @wwwdata could you please rebase (& start the next version number)

wwwdata · 2019-12-10T12:32:21Z

hi @wwwdata could you please rebase (& start the next version number)

Just rebased, increased version number and pushed. Thanks for the fast feedback

ened

Just a few tiny bits, but besides that looks good.

packages/webview_flutter/ios/Classes/FlutterWebView.m

packages/webview_flutter/ios/Classes/FLTWKHistoryDelegate.m

packages/webview_flutter/lib/platform_interface.dart

packages/webview_flutter/lib/webview_flutter.dart

wwwdata · 2019-12-10T13:01:48Z

@ened Thanks a lot for the good review feedback. Implemented the requested changes.

ened

LGTM as well

MattisBrizard · 2020-10-12T10:10:43Z

Hi @wwwdata, is this pull request still active ?
I also need this implementation, and see that's it is an old PR.
I see that it requires @amirh approval, any update on this feature ?
Thanks.

wwwdata · 2020-10-12T10:12:35Z

So far I didn't hear anything official... I would be happy to rebase and fix all conflicts here again if somebody then also does a review...

Send URL change events when the user navigates in the Browser. This also works for JavaScript Navigation that does not actually make any request.

wwwdata · 2020-10-13T13:16:50Z

Ok, it's rebased again. We're only in 10 months waiting for a review, so let's give it some time :)

jcgoodru · 2021-01-04T22:08:31Z

This would be a great feature to have :)

stuartmorgan-g

Thanks for the contribution! Looks like this fell through the cracks somehow, as it seems to have been approved but then not followed up on.

I've left a few more review comments; if you want to follow up on those and update to the current master, I can make sure this moves forward.

stuartmorgan-g · 2021-06-08T18:07:35Z

packages/webview_flutter/test/webview_flutter_test.dart

+
+    // TODO(hterkelsen): Remove this when defaultBinaryMessages is in stable.
+    // https://github.com/flutter/flutter/issues/33446
+    // ignore: deprecated_member_use


Looks like this is obsolete.

stuartmorgan-g · 2021-06-08T18:08:25Z

packages/webview_flutter/ios/Classes/FLTWKHistoryDelegate.h

+
+NS_ASSUME_NONNULL_BEGIN
+
+@interface FLTWKHistoryDelegate : NSObject


This class and its methods need declaration comments, per Google style.

stuartmorgan-g · 2021-06-08T18:09:40Z

packages/webview_flutter/ios/Classes/FLTWKHistoryDelegate.m

+  self = [super init];
+  if (self) {
+    _methodChannel = channel;
+    [webView addObserver:self


Why is this feature based on KVO rather than WKNavigationDelegate?

stuartmorgan-g · 2021-06-08T18:14:07Z

packages/webview_flutter/lib/platform_interface.dart

@@ -31,6 +31,9 @@ abstract class WebViewPlatformCallbacksHandler {

  /// Report web resource loading error to the host application.
  void onWebResourceError(WebResourceError error);
+
+  /// Invoked by [WebViewPlatformController] when the URL has changed.
+  void onUpdateVisitedHistory(String url);


The naming here seems very Android-centric; is there a reason not to call it something more generic like onUrlChanged?

stuartmorgan-g · 2021-06-08T18:14:39Z

packages/webview_flutter/ios/Classes/FLTWKHistoryDelegate.m

+
+#import "FLTWKHistoryDelegate.h"
+
+NSString *const keyPath = @"URL";


Nit: this should be static

Hixie · 2021-10-26T23:54:00Z

@wwwdata Any chance you have the time to look at this again? It looks like it's so close to landing.

christopherfujino · 2022-03-09T00:22:33Z

I am going to close this as stale. Feel free to re-open if you are going to rebase and apply requested changes.

stuartmorgan-g · 2022-03-09T02:48:24Z

I am planning to look at adapting this to the current state of the plugins once the iOS conversion to Dart+Pigeon is complete.

stuartmorgan-g · 2022-07-28T20:15:30Z

The Dart conversion is complete, but in the meantime we found flutter/flutter#94051 which blocks this, since we currently implement WebViewPlatformCallbacksHandler in our implementations, making changes to it breaking changes. We're actively working on that issue, and hope to have it resolved soon.

stuartmorgan-g · 2022-08-30T15:02:17Z

Status update from triage: this is still blocked, but we hope to have it unblocked soon.

stuartmorgan-g · 2023-01-11T19:31:14Z

This is unblocked now that v4 has landed. @bparrishMines This is one we should look at updating.

stuartmorgan-g · 2023-02-14T20:55:16Z

Closing as this was obsoleted by #7113; the implementation had changed enough that it was easiest to start a new PR rather than update this one. Thanks!

wwwdata requested a review from amirh as a code owner December 9, 2019 11:45

googlebot added the cla: yes label Dec 9, 2019

wwwdata force-pushed the webview-history-events branch from 6a640b0 to 02a610e Compare December 10, 2019 12:32

ened suggested changes Dec 10, 2019

View reviewed changes

wwwdata force-pushed the webview-history-events branch from 02a610e to 25fc5a2 Compare December 10, 2019 13:00

wwwdata requested a review from ened December 10, 2019 13:01

ened approved these changes Dec 10, 2019

View reviewed changes

wwwdata force-pushed the webview-history-events branch 2 times, most recently from 7d98ee3 to fbbc931 Compare December 13, 2019 08:24

[webview_flutter] Send history events

505f1a2

Send URL change events when the user navigates in the Browser. This also works for JavaScript Navigation that does not actually make any request.

wwwdata force-pushed the webview-history-events branch from fbbc931 to 505f1a2 Compare October 13, 2020 13:16

stuartmorgan-g added the p: webview_flutter Edits files for a webview_flutter plugin label Jan 29, 2021

stuartmorgan-g suggested changes Jun 8, 2021

View reviewed changes

stuartmorgan-g added the in review label Jun 8, 2021

stuartmorgan-g added the last mile label Sep 2, 2021

stuartmorgan-g removed the in review label Dec 19, 2021

godofredoc changed the base branch from master to main January 6, 2022 22:13

stuartmorgan-g removed the last mile label Jan 20, 2022

christopherfujino closed this Mar 9, 2022

github-actions bot added platform-android platform-ios labels Mar 9, 2022

stuartmorgan-g reopened this Mar 9, 2022

stuartmorgan-g closed this Feb 14, 2023


		NS_ASSUME_NONNULL_BEGIN

		@interface FLTWKHistoryDelegate : NSObject


		#import "FLTWKHistoryDelegate.h"

		NSString *const keyPath = @"URL";

[webview_flutter] Send history events #2379

[webview_flutter] Send history events #2379

Uh oh!

Conversation

wwwdata commented Dec 9, 2019

Description

Checklist

Breaking Change

Uh oh!

ened commented Dec 10, 2019

Uh oh!

wwwdata commented Dec 10, 2019

Uh oh!

ened left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wwwdata commented Dec 10, 2019

Uh oh!

ened left a comment

Choose a reason for hiding this comment

Uh oh!

MattisBrizard commented Oct 12, 2020

Uh oh!

wwwdata commented Oct 12, 2020

Uh oh!

wwwdata commented Oct 13, 2020

Uh oh!

jcgoodru commented Jan 4, 2021

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Jun 8, 2021

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Jun 8, 2021

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Jun 8, 2021

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Jun 8, 2021

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Jun 8, 2021

Choose a reason for hiding this comment

Uh oh!

Hixie commented Oct 26, 2021

Uh oh!

christopherfujino commented Mar 9, 2022

Uh oh!

stuartmorgan-g commented Mar 9, 2022

Uh oh!

stuartmorgan-g commented Jul 28, 2022

Uh oh!

stuartmorgan-g commented Aug 30, 2022

Uh oh!

stuartmorgan-g commented Jan 11, 2023

Uh oh!

stuartmorgan-g commented Feb 14, 2023

Uh oh!

Uh oh!