This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[all] Switch to pedantic analysis rules #2300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches our out of date fork of Flutter's analysis rules to the pedantic package. In order to make this an easy change to initially land and then incrementally enable, any existing non-trivial lints have just been ignored within their respective packages instead of being fixed. Also adds a global lint for missing public DartDocs. Like the pedantic lints, this being ignored in packages that are already failing it.
mklim
requested review from
amirh,
bkonyi,
bparrishMines,
collinjackson,
cyanglaz and
iskakaushik
as code owners
13 tasks
mklim
commented
Nov 23, 2019
Comment on lines
+5
to
+9
| // This is a temporary ignore to allow us to land a new set of linter rules in a | ||
| // series of manageable patches instead of one gigantic PR. It disables some of | ||
| // the new lints that are already failing on this plugin, for this plugin. It | ||
| // should be deleted and the failing lints addressed as soon as possible. | ||
| // ignore_for_file: public_member_api_docs |
There was a problem hiding this comment.
Originally I tried putting in an analysis_options.yaml for this plugin like everywhere else, but for some reason this particular plugin was having issues importing the pedantic package transitively when running pub global tuneup. No idea why as the package was showing as included in the pubspec.lock and nothing looked different from any of the other packages. Seems like some kind of bug to me in pub or the linter to me. I'm just working around it by putting the ignores in the source code directly instead. It's not ideal, but it shouldn't matter since in the long term this should be fixed anyway.
collinjackson
approved these changes
Nov 25, 2019
| @@ -10,6 +10,6 @@ Future<void> main() async { | |||
| final FlutterDriver driver = await FlutterDriver.connect(); | |||
| final String result = | |||
| await driver.requestData(null, timeout: const Duration(minutes: 1)); | |||
| driver.close(); | |||
| await driver.close(); | |||
There was a problem hiding this comment.
Wow, this is a good catch.
This was referenced Nov 26, 2019
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
Switches our out of date fork of Flutter's analysis rules to the pedantic package. In order to make this an easy change to initially land and then incrementally enable, any existing non-trivial lints have just been ignored within their respective packages instead of being fixed. Also adds a global lint for missing public DartDocs. Like the pedantic lints, this is ignored in packages that are already failing it.
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Switches our out of date fork of Flutter's analysis rules to the pedantic package. In order to make this an easy change to initially land and then incrementally enable, any existing failures have just been ignored within their respective packages instead of being fixed. Also adds a global lint for missing public DartDocs. Like the pedantic lints, this is ignored in packages that are already failing it. This is a mirror of a similar change to flutter/plugins, flutter#2300.
Akachu
pushed a commit
to Akachu/flutter_camera
that referenced
this pull request
Apr 27, 2020
Switches our out of date fork of Flutter's analysis rules to the pedantic package. In order to make this an easy change to initially land and then incrementally enable, any existing non-trivial lints have just been ignored within their respective packages instead of being fixed. Also adds a global lint for missing public DartDocs. Like the pedantic lints, this is ignored in packages that are already failing it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switches our out of date fork of Flutter's analysis rules to the
pedantic package. In order to make this an easy change to initially land
and then incrementally enable, any existing non-trivial lints have just
been ignored within their respective packages instead of being fixed.
Also adds a global lint for missing public DartDocs. Like the pedantic
lints, this is ignored in packages that are already failing it.
Related Issues
flutter/flutter#45440
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?