Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[share] add native file sharing feature #1423

Closed
wants to merge 11 commits into from

Conversation

Kiruel
Copy link

@Kiruel Kiruel commented Mar 29, 2019

Add native file sharing functionality and fix issue from #970

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@ca333
Copy link

ca333 commented Mar 29, 2019

I signed it!

@Kiruel Kiruel changed the title add native file sharing feature [share] add native file sharing feature Mar 29, 2019
@ca333
Copy link

ca333 commented Mar 29, 2019

@ianloic @sethladd can you plz help us - we signed both the CLA but the commit email is diff. We cant change that. Can you set cla:yes plz

@bbedward
Copy link

Would love to see this get merged, I've been using it for months now as a git dependency.

@Kiruel
Copy link
Author

Kiruel commented Sep 25, 2019

I signed it.

@Kiruel
Copy link
Author

Kiruel commented Sep 25, 2019

@ianloic @sethladd Hi guys, how many time we need to wait for this PR ? (opening in mars 2019.)

@Kiruel
Copy link
Author

Kiruel commented Sep 25, 2019

Btw I use this change in my main project with no problem during all this months.

@pboos
Copy link
Contributor

pboos commented Jan 3, 2020

Thanks for your fixes :). Didn't see this pull request. Could probably have saved myself time rewriting everything and start off from your branch!
I have updated my pull request #970 and actually fixed a small bug that seems to exist in this code (on iOS related to text + file if I remember correctly).

Please try my branch to see if that one works for you as well. Or if you have any comments there.

@Kiruel Kiruel closed this Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants