Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[Cloud_firestore]add type params for invokeMethod calls. #1414

Merged
merged 3 commits into from
Mar 29, 2019

Conversation

cyanglaz
Copy link
Contributor

Description

Bump min flutter version to 1.2.0.
Add template type parameter for invokeMethod calls.
Updated invokeMethod and invokeMethod to using invokeListMethod and invokeMapMethod if any.
Anything that will change the type of a public API should not be included in this PR.

Related Issues

flutter/flutter#26431

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

## 0.9.7+2

* Bump the minimum flutter version to 1.2.0.
* Add Template type parameter to `invokeMethod` calls.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't capitalize this

@@ -1,3 +1,8 @@
## 0.9.7+2

* Bump the minimum flutter version to 1.2.0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize Flutter

@collinjackson
Copy link
Contributor

lgtm

@cyanglaz cyanglaz merged commit d4fd64f into flutter:master Mar 29, 2019
@cyanglaz cyanglaz deleted the cloud_firestore branch March 29, 2019 16:47
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Bump min flutter version to 1.2.0.
Add template type parameter for invokeMethod calls.
Updated invokeMethod and invokeMethod to using invokeListMethod and invokeMapMethod if any.

flutter/flutter#26431
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants