-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[video_player] Adds audio track metadata fetching and audio track selection feature #9925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a valuable feature for fetching and selecting audio tracks in the video_player package. The changes are comprehensive, touching the platform interface, Android (ExoPlayer) and iOS (AVFoundation) implementations, and adding a new demo screen.
My review has identified several critical and high-severity issues that should be addressed:
- The new native unit tests for both Android and iOS appear to be broken due to type mismatches and incorrect method calls, and will not compile in their current state.
- The Dart implementation code for both Android and iOS contains unsafe null assertions on data coming from the native side, which could lead to runtime crashes.
- The Android implementation has been updated to use a milestone version of Gradle, which is not recommended for production packages.
- The new audio track selection feature has not been implemented for the web platform, which will lead to
UnimplementedError
on web. - There is a minor issue in the new example app where
context
is used after anawait
without checking if the widget is still mounted.
Addressing these points will significantly improve the robustness and completeness of this new feature.
...deo_player_android/android/src/test/java/io/flutter/plugins/videoplayer/AudioTracksTest.java
Outdated
Show resolved
Hide resolved
packages/video_player/video_player_avfoundation/darwin/RunnerTests/AudioTracksTests.m
Outdated
Show resolved
Hide resolved
packages/video_player/video_player_android/android/gradle/wrapper/gradle-wrapper.properties
Outdated
Show resolved
Hide resolved
packages/video_player/video_player_android/lib/src/android_video_player.dart
Outdated
Show resolved
Hide resolved
packages/video_player/video_player_avfoundation/lib/src/avfoundation_video_player.dart
Outdated
Show resolved
Hide resolved
…oPlayer async updates
… fix format builders
I updated native andorid tests and ran the tests and verified that all native android tests are passing. |
fix(ios): fixed tests
@stuartmorgan-g @ash2moon can you please comment on this PR and lemme know if there are any concerns ? |
19 sept pr review changes
feat(video_player): add platform check for audio track selection support
@LongCatIsLooong Have updated code based on review comments and added api support query check to return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
web changes look good!
For future reference, if someone decides to work on web support, here's a good starting point: https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/audioTracks
The new files here will require a minor change to the license header when you merge in |
i'm not understanding this, can u please elaborate ? |
This line will fail the license check after your next merge from |
Pushed the change. pls check @stuartmorgan-g |
any update on this PR ? what should i do next to get this merged ? |
Our CI checks the license conformance.
It still needs review and approval from @tarrinneal, @ash2moon, and @LongCatIsLooong |
Description
This PR adds comprehensive audio track retrieval and selection support to the video_player package, enabling developers to access detailed information about available audio tracks and switch between them during playback.
Changes Made
Core Features
VideoAudioTrack
model with comprehensive metadata fields:id
,label
,language
,isSelected
,bitrate
,sampleRate
,channelCount
,codec
VideoPlayerController
to expose audio track functionalityPlatform Implementations
getCurrentTracks()
APITrackSelectionOverride
with proper error handlingAVAssetTrack
for regular videosAVMediaSelectionGroup
for adaptive streamsTechnical Infrastructure
AudioTrackMessage
,ExoPlayerAudioTrackData
,AssetAudioTrackData
,MediaSelectionAudioTrackData
,NativeAudioTrackData
Demo Features
Related Issues
#59437 - Add audio track metadata support to video_player
Testing
Breaking Changes
None - all changes are additive and backward compatible.
Pre-Review Checklist
[video_player]
pubspec.yaml
with an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].CHANGELOG.md
to add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].///
).