Skip to content

[webview_flutter_wkwebview] Replace Flutter method failure assertion with nslog #9587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Jul 10, 2025

The assertion caused a crash with hot restart if a Flutter method call happened at the same time. Changing this to NSLog also allows logging failures when in release mode.

Fixes flutter/flutter#170643

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@bparrishMines bparrishMines changed the title Wkwebview log error [webview_flutter_wkwebview] Replace Flutter method failure assertion with nslog Jul 11, 2025
@bparrishMines bparrishMines marked this pull request as ready for review July 11, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[webview_flutter] Crash upon hot restart in iOS
1 participant