Skip to content

Bump AVD and SDK to API 36 in Packages CI #9414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 17 additions & 16 deletions .ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,11 @@ platform_properties:
device_type: none
dependencies: >-
[
{"dependency": "android_sdk", "version": "version:33v6"},
{"dependency": "android_sdk", "version": "version:36v1"},
{"dependency": "open_jdk", "version": "version:17"},
{"dependency": "curl", "version": "version:7.64.0"},
{"dependency": "avd_cipd_version", "version": "build_id:8733065022087935185"}
{"dependency": "android_virtual_device", "version": "android_36_google_apis_x64.textpb"},
{"dependency": "avd_cipd_version", "version": "build_id:8719362231152674241"}
]
linux_android_legacy:
properties:
Expand Down Expand Up @@ -362,7 +363,7 @@ targets:
# web_benchmarks needs Chrome.
dependencies: >-
[
{"dependency": "android_virtual_device", "version": "android_34_google_apis_x64.textpb"},
{"dependency": "android_virtual_device", "version": "android_36_google_apis_x64.textpb"},
{"dependency": "clang", "version": "git_revision:5d5aba78dbbee75508f01bcaa69aedb2ab79065a"},
{"dependency": "cmake", "version": "build_id:8787856497187628321"},
{"dependency": "ninja", "version": "version:1.9.0"},
Expand All @@ -385,7 +386,7 @@ targets:
# See comments on 'master' version above.
dependencies: >-
[
{"dependency": "android_virtual_device", "version": "android_34_google_apis_x64.textpb"},
{"dependency": "android_virtual_device", "version": "android_36_google_apis_x64.textpb"},
{"dependency": "clang", "version": "git_revision:5d5aba78dbbee75508f01bcaa69aedb2ab79065a"},
{"dependency": "cmake", "version": "build_id:8787856497187628321"},
{"dependency": "ninja", "version": "version:1.9.0"},
Expand Down Expand Up @@ -435,7 +436,7 @@ targets:
package_sharding: "--shardIndex 0 --shardCount 6"
dependencies: >-
[
{"dependency": "android_virtual_device", "version": "android_34_google_apis_x64.textpb"}
{"dependency": "android_virtual_device", "version": "android_36_google_apis_x64.textpb"}
]
env_variables: >-
{
Expand All @@ -453,7 +454,7 @@ targets:
package_sharding: "--shardIndex 1 --shardCount 6"
dependencies: >-
[
{"dependency": "android_virtual_device", "version": "android_34_google_apis_x64.textpb"}
{"dependency": "android_virtual_device", "version": "android_36_google_apis_x64.textpb"}
]
env_variables: >-
{
Expand All @@ -471,7 +472,7 @@ targets:
package_sharding: "--shardIndex 2 --shardCount 6"
dependencies: >-
[
{"dependency": "android_virtual_device", "version": "android_34_google_apis_x64.textpb"}
{"dependency": "android_virtual_device", "version": "android_36_google_apis_x64.textpb"}
]
env_variables: >-
{
Expand All @@ -489,7 +490,7 @@ targets:
package_sharding: "--shardIndex 3 --shardCount 6"
dependencies: >-
[
{"dependency": "android_virtual_device", "version": "android_34_google_apis_x64.textpb"}
{"dependency": "android_virtual_device", "version": "android_36_google_apis_x64.textpb"}
]
env_variables: >-
{
Expand All @@ -507,7 +508,7 @@ targets:
package_sharding: "--shardIndex 4 --shardCount 6"
dependencies: >-
[
{"dependency": "android_virtual_device", "version": "android_34_google_apis_x64.textpb"}
{"dependency": "android_virtual_device", "version": "android_36_google_apis_x64.textpb"}
]
env_variables: >-
{
Expand All @@ -525,7 +526,7 @@ targets:
package_sharding: "--shardIndex 5 --shardCount 6"
dependencies: >-
[
{"dependency": "android_virtual_device", "version": "android_34_google_apis_x64.textpb"}
{"dependency": "android_virtual_device", "version": "android_36_google_apis_x64.textpb"}
]
env_variables: >-
{
Expand All @@ -544,7 +545,7 @@ targets:
package_sharding: "--shardIndex 0 --shardCount 6"
dependencies: >-
[
{"dependency": "android_virtual_device", "version": "android_34_google_apis_x64.textpb"}
{"dependency": "android_virtual_device", "version": "android_36_google_apis_x64.textpb"}
]
env_variables: >-
{
Expand All @@ -563,7 +564,7 @@ targets:
package_sharding: "--shardIndex 1 --shardCount 6"
dependencies: >-
[
{"dependency": "android_virtual_device", "version": "android_34_google_apis_x64.textpb"}
{"dependency": "android_virtual_device", "version": "android_36_google_apis_x64.textpb"}
]
env_variables: >-
{
Expand All @@ -582,7 +583,7 @@ targets:
package_sharding: "--shardIndex 2 --shardCount 6"
dependencies: >-
[
{"dependency": "android_virtual_device", "version": "android_34_google_apis_x64.textpb"}
{"dependency": "android_virtual_device", "version": "android_36_google_apis_x64.textpb"}
]
env_variables: >-
{
Expand All @@ -601,7 +602,7 @@ targets:
package_sharding: "--shardIndex 3 --shardCount 6"
dependencies: >-
[
{"dependency": "android_virtual_device", "version": "android_34_google_apis_x64.textpb"}
{"dependency": "android_virtual_device", "version": "android_36_google_apis_x64.textpb"}
]
env_variables: >-
{
Expand All @@ -620,7 +621,7 @@ targets:
package_sharding: "--shardIndex 4 --shardCount 6"
dependencies: >-
[
{"dependency": "android_virtual_device", "version": "android_34_google_apis_x64.textpb"}
{"dependency": "android_virtual_device", "version": "android_36_google_apis_x64.textpb"}
]
env_variables: >-
{
Expand All @@ -639,7 +640,7 @@ targets:
package_sharding: "--shardIndex 5 --shardCount 6"
dependencies: >-
[
{"dependency": "android_virtual_device", "version": "android_34_google_apis_x64.textpb"}
{"dependency": "android_virtual_device", "version": "android_36_google_apis_x64.textpb"}
]
env_variables: >-
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -535,8 +535,13 @@ Future<void> main() async {
// Makes sure we get the correct event that indicates the video is actually playing.
await videoPlaying.future;

final bool fullScreen = await controller
.runJavaScriptReturningResult('isFullScreen();') as bool;
dynamic fullScreen =
await controller.runJavaScriptReturningResult('isFullScreen();');

if (fullScreen is String) {
fullScreen = fullScreen == 'isFullScreen();';
}

expect(fullScreen, false);
});

Expand Down