Skip to content

Ignore .cxx/ directories #9268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ GeneratedPluginRegistrant.*
.gradle/
gradlew
gradlew.bat
.cxx/

.project
.classpath
Expand Down
8 changes: 7 additions & 1 deletion script/tool/lib/src/drive_examples_command.dart
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,13 @@ class DriveExamplesCommand extends PackageLoopingCommand {

@override
bool shouldIgnoreFile(String path) {
return isRepoLevelNonCodeImpactingFile(path) || isPackageSupportFile(path);
return isRepoLevelNonCodeImpactingFile(path) ||
isPackageSupportFile(path) ||
// This isn't part of isRepoLevelNonCodeImpactingFile since there could
// potentially be code-based commands that it could affect, but it
// should not affect integration tests, and they are the most expensive
// and flaky tests.
path == '.gitignore';
}

@override
Expand Down
1 change: 1 addition & 0 deletions script/tool/test/drive_examples_command_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1763,6 +1763,7 @@ packages/package_a/$file
FakeProcessInfo(MockProcess(stdout: '''
README.md
CODEOWNERS
.gitignore
packages/package_a/CHANGELOG.md
''')),
];
Expand Down