[go_router_builder] Fixes an deprecated warning for using withNullability #9158
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
| @@ -438,6 +438,17 @@ extension ParameterElementExtension on ParameterElement { | |||
| bool get isExtraField => name == extraFieldName; | |||
| } | |||
|
|
|||
| /// Extension helpers on [String] for nullability check. | |||
| extension TypeStringExtensions on String { | |||
There was a problem hiding this comment.
We should avoid using extension as much as possible, I know we use elsewhere in go_router package, but they are against flutter style guide and we shouldn't add more
…y-deprecate-warning # Conflicts: # packages/go_router_builder/CHANGELOG.md # packages/go_router_builder/pubspec.yaml
chunhtai
added
the
autosubmit
flutter/packages@ab44c26...7814fab 2025-05-08 40433176+KevynSM@users.noreply.github.com [go_router] Fix requestFocus propagation to Navigator (flutter/packages#9177) 2025-05-08 65381000+raju8000@users.noreply.github.com [go_router_builder] Fixes an deprecated warning for using withNullability (flutter/packages#9158) 2025-05-08 engine-flutter-autoroll@skia.org Roll Flutter from b0f5c8c to 02d8c1a (19 revisions) (flutter/packages#9230) 2025-05-08 43054281+camsim99@users.noreply.github.com [camera_android_camerax] Fix camera preview rotation for landscape oriented devices (flutter/packages#9097) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lity (flutter#9158) *List which issues are fixed by this PR. You must list at least one issue.* [Issue #166603](flutter/flutter#166603) ## Pre-Review Checklist
List which issues are fixed by this PR. You must list at least one issue.
fixes Issue #166603
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].///).