-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[camera_avfoundation] Tests backfilling - part 4 #8854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 4 commits into
flutter:main
from
leancodepl:feature/camera-tests-backfilling-part4
Mar 19, 2025
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
109 changes: 109 additions & 0 deletions
109
.../camera/camera_avfoundation/example/ios/RunnerTests/FLTCamSetDeviceOrientationTests.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| // Copyright 2013 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| import AVFoundation | ||
| import XCTest | ||
|
|
||
| @testable import camera_avfoundation | ||
|
|
||
| final class FLTCamSetDeviceOrientationTests: XCTestCase { | ||
| private func createCamera() -> (FLTCam, MockCaptureConnection, MockCaptureConnection) { | ||
| let configuration = FLTCreateTestCameraConfiguration() | ||
| let camera = FLTCreateCamWithConfiguration(configuration) | ||
|
|
||
| let mockCapturePhotoOutput = MockCapturePhotoOutput() | ||
| let mockPhotoCaptureConnection = MockCaptureConnection() | ||
| mockPhotoCaptureConnection.isVideoOrientationSupported = true | ||
|
|
||
| mockCapturePhotoOutput.connectionWithMediaTypeStub = { _ in mockPhotoCaptureConnection } | ||
| camera.capturePhotoOutput = mockCapturePhotoOutput | ||
|
|
||
| let mockCaptureVideoDataOutput = MockCaptureVideoDataOutput() | ||
| let mockVideoCaptureConnection = MockCaptureConnection() | ||
| mockVideoCaptureConnection.isVideoOrientationSupported = true | ||
|
|
||
| mockCaptureVideoDataOutput.connectionWithMediaTypeStub = { _ in mockVideoCaptureConnection } | ||
| camera.captureVideoOutput = mockCaptureVideoDataOutput | ||
|
|
||
| return (camera, mockPhotoCaptureConnection, mockVideoCaptureConnection) | ||
| } | ||
|
|
||
| func testSetDeviceOrientation_setsOrientationsOfCaptureConnections() { | ||
| let (camera, mockPhotoCaptureConnection, mockVideoCaptureConnection) = createCamera() | ||
| var photoSetVideoOrientationCalled = false | ||
| mockPhotoCaptureConnection.setVideoOrientationStub = { orientation in | ||
| // Device orientation is flipped compared to video orientation. When UIDeviceOrientation | ||
| // is landscape left the video orientation should be landscape right. | ||
| XCTAssertEqual(orientation, .landscapeRight) | ||
| photoSetVideoOrientationCalled = true | ||
| } | ||
|
|
||
| var videoSetVideoOrientationCalled = false | ||
| mockVideoCaptureConnection.setVideoOrientationStub = { orientation in | ||
| // Device orientation is flipped compared to video orientation. When UIDeviceOrientation | ||
| // is landscape left the video orientation should be landscape right. | ||
| XCTAssertEqual(orientation, .landscapeRight) | ||
| videoSetVideoOrientationCalled = true | ||
| } | ||
|
|
||
| camera.setDeviceOrientation(.landscapeLeft) | ||
|
|
||
| XCTAssertTrue(photoSetVideoOrientationCalled) | ||
| XCTAssertTrue(videoSetVideoOrientationCalled) | ||
| } | ||
|
|
||
| func | ||
| testSetDeviceOrientation_setsLockedOrientationsOfCaptureConnection_ifCaptureOrientationIsLocked() | ||
| { | ||
| let (camera, mockPhotoCaptureConnection, mockVideoCaptureConnection) = createCamera() | ||
| var photoSetVideoOrientationCalled = false | ||
| mockPhotoCaptureConnection.setVideoOrientationStub = { orientation in | ||
| XCTAssertEqual(orientation, .portraitUpsideDown) | ||
| photoSetVideoOrientationCalled = true | ||
| } | ||
|
|
||
| var videoSetVideoOrientationCalled = false | ||
| mockVideoCaptureConnection.setVideoOrientationStub = { orientation in | ||
| XCTAssertEqual(orientation, .portraitUpsideDown) | ||
| videoSetVideoOrientationCalled = true | ||
| } | ||
|
|
||
| camera.lockCapture(FCPPlatformDeviceOrientation.portraitDown) | ||
|
|
||
| camera.setDeviceOrientation(.landscapeLeft) | ||
|
|
||
| XCTAssertTrue(photoSetVideoOrientationCalled) | ||
| XCTAssertTrue(videoSetVideoOrientationCalled) | ||
| } | ||
|
|
||
| func testSetDeviceOrientation_doesNotSetOrientations_ifRecordingIsInProgress() { | ||
| let (camera, mockPhotoCaptureConnection, mockVideoCaptureConnection) = createCamera() | ||
|
|
||
| camera.startVideoRecording(completion: { _ in }, messengerForStreaming: nil) | ||
|
|
||
| mockPhotoCaptureConnection.setVideoOrientationStub = { _ in XCTFail() } | ||
| mockVideoCaptureConnection.setVideoOrientationStub = { _ in XCTFail() } | ||
|
|
||
| camera.setDeviceOrientation(.landscapeLeft) | ||
| } | ||
|
|
||
| func testSetDeviceOrientation_doesNotSetOrientations_forDuplicateUpdates() { | ||
| let (camera, mockPhotoCaptureConnection, mockVideoCaptureConnection) = createCamera() | ||
| var photoSetVideoOrientationCallCount = 0 | ||
| mockPhotoCaptureConnection.setVideoOrientationStub = { _ in | ||
| photoSetVideoOrientationCallCount += 1 | ||
| } | ||
|
|
||
| var videoSetVideoOrientationCallCount = 0 | ||
| mockVideoCaptureConnection.setVideoOrientationStub = { _ in | ||
| videoSetVideoOrientationCallCount += 1 | ||
| } | ||
|
|
||
| camera.setDeviceOrientation(.landscapeRight) | ||
| camera.setDeviceOrientation(.landscapeRight) | ||
|
|
||
| XCTAssertEqual(photoSetVideoOrientationCallCount, 1) | ||
| XCTAssertEqual(videoSetVideoOrientationCallCount, 1) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
...camera/camera_avfoundation/example/ios/RunnerTests/Mocks/MockCaptureVideoDataOutput.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| // Copyright 2013 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| /// Mock implementation of `FLTCaptureVideoDataOutput` protocol which allows injecting a custom | ||
| /// implementation. | ||
| class MockCaptureVideoDataOutput: NSObject, FLTCaptureVideoDataOutput { | ||
|
|
||
| var avOutput = AVCaptureVideoDataOutput() | ||
| var alwaysDiscardsLateVideoFrames = false | ||
| var videoSettings: [String: Any] = [:] | ||
|
|
||
| var connectionWithMediaTypeStub: ((AVMediaType) -> FLTCaptureConnection?)? | ||
|
|
||
| func connection(withMediaType mediaType: AVMediaType) -> FLTCaptureConnection? { | ||
| return connectionWithMediaTypeStub?(mediaType) | ||
| } | ||
|
|
||
| func setSampleBufferDelegate( | ||
| _ sampleBufferDelegate: AVCaptureVideoDataOutputSampleBufferDelegate?, | ||
| queue sampleBufferCallbackQueue: DispatchQueue? | ||
| ) {} | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.