Manual roll Flutter from 911aa7547ed7 to 043b71954ce7 #8693

stuartmorgan-g · 2025-02-24T20:06:30Z

#8692 with fixes for indirect effects of --explicit-package-dependencies

flutter-dashboard · 2025-02-24T20:06:35Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

reidbaker · 2025-02-24T20:08:02Z

.ci/flutter_master.version

Where can I read more about how this file works in the package repo

I don't know that it's specifically documented anywhere, but its used in ci.yaml (example), and it's rolled by the auto-roller. The generic packages recipe uses that ci.yaml file to control the Flutter version that is checked out.

reidbaker · 2025-02-24T20:09:08Z

.../src/main/java/io/flutter/plugins/flutter_plugin_android_lifecycle_example/MainActivity.java

    flutterEngine.getPlugins().add(new TestPlugin());
-    flutterEngine.getPlugins().add(new IntegrationTestPlugin());


Why do we not need the integration test plugin? was it dead code?

This is a speculative change, but the fact that this wasn't calling super seems suspicious. Normally plugins are registered by the generated registrant.

This wasn't compiling because it's unconditionally using the integration test plugin, but that plugin is a dev dependency. If this doesn't work, I'll need to make this example app have a non-dev dependency on it instead, but that feels wrong.

reidbaker · 2025-02-24T20:18:10Z

packages/interactive_media_ads/android/build.gradle

@@ -54,7 +54,7 @@ android {
        testImplementation 'org.jetbrains.kotlin:kotlin-test'
        testImplementation "org.mockito.kotlin:mockito-kotlin:5.4.0"
        testImplementation 'org.mockito:mockito-inline:5.1.0'
-        testImplementation 'androidx.test:core:1.3.0'


FYI I filed flutter/flutter#164025 to track making these updates easier.

stuartmorgan-g · 2025-02-24T21:38:47Z

Looks like some tests are failing now; I'll investigate further tomorrow.

stuartmorgan-g · 2025-02-25T00:00:06Z

Hm, it looks like integration tests are failing pretty much across the board. @matanlurey Did you test with your changes to see if the instructions here and here are still correct? I'm wondering if having a dev dependency on integration_test is no longer sufficient for FTL tests.

matanlurey · 2025-02-25T00:11:52Z

Hm, it looks like integration tests are failing pretty much across the board. @matanlurey Did you test with your changes to see if the instructions here and here are still correct? I'm wondering if having a dev dependency on integration_test is no longer sufficient for FTL tests.

Neither of those two steps should have been impacted. The scenario I could imagine breaking is if the result of flutter build apk (which defaults to --release) is what was being deployed.

To test that theory you could move the dependency from dev_dependencies to dependencies.

Otherwise I would slap the config opt-out and assign me a P1, and I'll look at it tomorrow morning, and rollback the flag if there isn't a revert. Bonus points if there is a local repro.

stuartmorgan-g · 2025-02-25T19:28:44Z

@stuartmorgan Can you try changing this to pass --debug (or --profile if perf concerns)?

Running that now. Where exactly will the difference show up? I wasn't sure what part of the project to look at to see the difference in what these commands output.

FYI (@reidbaker FYI as well since he implemented the Android version of --config-only), in generally flutter's structure has been that once the project files have been generated by building once, developers are free to change their build mode later via native tooling. E.g., on iOS you can flutter build once, then open Xcode, and make Debug and Release builds without re-running flutter build. It sounds like that use case has a new failure mode? (In the past there were cases where that didn't work, but they were more niche than having a dev dependency on a plugin.)

reidbaker · 2025-02-25T19:32:55Z

Fwiw my naive answer is that config only should not care what release mode you use.

The actual build cares because it is the same as changing the running gradle tasks.

stuartmorgan-g · 2025-02-25T20:12:09Z

It looks like re-running flutter build --debug did in fact work. I filed flutter/flutter#164133 to discuss the fact that this is an unfortunate regression, which ideally we would fix.

This is pulled out of #8693 to land on its own while the other issues with that PR are investigated, since it's a useful change regardless. This updates all packages in the repo to have `androidx.test:core` 1.4.0 if it's not already higher. This fixes a latent problem where older versions of `androidx.test.core` aren't compatible with targeting the current SDK, because it has activities that are not annotated as exported. This issue is currently being masked by the dependency on `integration_test`, which forced a higher version of that package, but `integration_test` will stop exporting that dependency onto the app as of recent master, dropping all the packages here back to a too-old `androidx.test:core`.

stuartmorgan-g · 2025-02-27T01:25:20Z

CHANGELOG override: minor change to an internal implementation detail of an example does not need a client-facing log entry.

…es#8693)

flutter/packages@c44c228...01d3d5c 2025-02-27 engine-flutter-autoroll@skia.org Manual roll Flutter from 043b719 to 1659206 (19 revisions) (flutter/packages#8728) 2025-02-27 stuartmorgan@google.com Manual roll Flutter from 911aa75 to 043b719 (flutter/packages#8693) 2025-02-26 magder@google.com Dependabot to update major and minor versions of test dependencies, ignore patch (flutter/packages#8712) 2025-02-26 reidbaker@google.com [local_auth] Update to use flutter.targetSdkVersion (flutter/packages#8695) 2025-02-26 57854043+CaoGiaHieu-dev@users.noreply.github.com [go_router_builder]: Handle invaild params (flutter/packages#8405) 2025-02-26 stuartmorgan@google.com [pigeon] Timestamp test steps in CI (flutter/packages#8716) 2025-02-26 43054281+camsim99@users.noreply.github.com [camera_android_camerax] Fix 90°-off preview rotation (flutter/packages#8629) 2025-02-26 108667553+aprzedecki@users.noreply.github.com [go_router] Secured empty matches in canPop (flutter/packages#8557) 2025-02-26 reidbaker@google.com [tool] Update targetsdk version to 35 from 32 (flutter/packages#8694) 2025-02-26 stuartmorgan@google.com [various] Bump androidx.test:core to 1.4.0 (flutter/packages#8710) 2025-02-26 stuartmorgan@google.com [camera] Disable flaky tests (flutter/packages#8708) 2025-02-26 mdebbar@google.com [url_launcher][web] Prevent browser from navigating when followLink isn't called (flutter/packages#8675) 2025-02-26 stuartmorgan@google.com [various] Remove plugin-level `integration_test` dependencies (flutter/packages#8711) 2025-02-26 stuartmorgan@google.com [ci] Lengthen custom tests timeout (flutter/packages#8715) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This is pulled out of flutter/packages#8693 to land on its own while the other issues with that PR are investigated, since it's a useful change regardless. This updates all packages in the repo to have `androidx.test:core` 1.4.0 if it's not already higher. This fixes a latent problem where older versions of `androidx.test.core` aren't compatible with targeting the current SDK, because it has activities that are not annotated as exported. This issue is currently being masked by the dependency on `integration_test`, which forced a higher version of that package, but `integration_test` will stop exporting that dependency onto the app as of recent master, dropping all the packages here back to a too-old `androidx.test:core`.

This is pulled out of flutter#8693 to land on its own while the other issues with that PR are investigated, since it's a useful change regardless. This updates all packages in the repo to have `androidx.test:core` 1.4.0 if it's not already higher. This fixes a latent problem where older versions of `androidx.test.core` aren't compatible with targeting the current SDK, because it has activities that are not annotated as exported. This issue is currently being masked by the dependency on `integration_test`, which forced a higher version of that package, but `integration_test` will stop exporting that dependency onto the app as of recent master, dropping all the packages here back to a too-old `androidx.test:core`.

flutter#8692 with fixes for indirect effects of `--explicit-package-dependencies`

This is pulled out of flutter#8693 to land on its own while the other issues with that PR are investigated, since it's a useful change regardless. This updates all packages in the repo to have `androidx.test:core` 1.4.0 if it's not already higher. This fixes a latent problem where older versions of `androidx.test.core` aren't compatible with targeting the current SDK, because it has activities that are not annotated as exported. This issue is currently being masked by the dependency on `integration_test`, which forced a higher version of that package, but `integration_test` will stop exporting that dependency onto the app as of recent master, dropping all the packages here back to a too-old `androidx.test:core`.

flutter#8692 with fixes for indirect effects of `--explicit-package-dependencies`

stuartmorgan-g added 3 commits February 24, 2025 14:52

Roll master

7cfb236

Bump androidx.test:core to at least 1.4.0 across the repo

7787e9f

Don't force integration test plugin dependency

c0f3a6b

stuartmorgan-g requested review from bparrishMines, camsim99, matanlurey, gmackall, reidbaker and tarrinneal as code owners February 24, 2025 20:06

github-actions bot added p: file_selector p: flutter_plugin_android_lifecycle p: google_maps_flutter p: google_sign_in p: image_picker p: quick_actions platform-android p: webview_flutter p: video_player p: url_launcher p: interactive_media_ads Plugin for IMA SDK labels Feb 24, 2025

reidbaker approved these changes Feb 24, 2025

View reviewed changes

tarrinneal approved these changes Feb 24, 2025

View reviewed changes

stuartmorgan-g added 2 commits February 24, 2025 16:35

Remove accidentally added annotation

d02abdf

No need to store the engine

860339f

Try making deps non-dev in camera

0ee396c

github-actions bot added the p: camera label Feb 25, 2025

This was referenced Feb 25, 2025

[various] Bump androidx.test:core to 1.4.0 #8710

Merged

Consider determining plugin state from calling back into flutter instead as a pre-generation step flutter/flutter#164133

Open

Merge branch 'main' into manual-roll-043b71954ce7

2ad8dac

Merge branch 'main' into manual-roll-043b71954ce7

617dcde

github-actions bot removed p: file_selector p: google_maps_flutter p: google_sign_in p: image_picker p: quick_actions p: webview_flutter p: video_player p: url_launcher p: interactive_media_ads Plugin for IMA SDK labels Feb 26, 2025

stuartmorgan-g added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Feb 27, 2025

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2025

auto-submit bot merged commit b5e8daa into flutter:main Feb 27, 2025
82 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 27, 2025

b5e8daa5c Manual roll Flutter from 911aa75 to 043b719 (flutter/packag…

53dc318

…es#8693)

engine-flutter-autoroll mentioned this pull request Feb 27, 2025

Roll Packages from c44c2282aad1 to 01d3d5c1dca3 (14 revisions) flutter/flutter#164301

Merged

androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025

Manual roll Flutter from 911aa75 to 043b719 (flutter#8693)

079fba2

flutter#8692 with fixes for indirect effects of `--explicit-package-dependencies`

FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025

Manual roll Flutter from 911aa75 to 043b719 (flutter#8693)

59fa2fc

flutter#8692 with fixes for indirect effects of `--explicit-package-dependencies`

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Manual roll Flutter from 911aa7547ed7 to 043b71954ce7 #8693

Manual roll Flutter from 911aa7547ed7 to 043b71954ce7 #8693

Uh oh!

stuartmorgan-g commented Feb 24, 2025

Uh oh!

flutter-dashboard bot commented Feb 24, 2025

Uh oh!

reidbaker Feb 24, 2025

Uh oh!

stuartmorgan-g Feb 24, 2025

Uh oh!

reidbaker Feb 24, 2025

Uh oh!

stuartmorgan-g Feb 24, 2025

Uh oh!

reidbaker Feb 24, 2025

Uh oh!

stuartmorgan-g commented Feb 24, 2025

Uh oh!

stuartmorgan-g commented Feb 25, 2025

Uh oh!

matanlurey commented Feb 25, 2025

Uh oh!

stuartmorgan-g commented Feb 25, 2025

Uh oh!

reidbaker commented Feb 25, 2025

Uh oh!

stuartmorgan-g commented Feb 25, 2025

Uh oh!

stuartmorgan-g commented Feb 27, 2025

Uh oh!

Uh oh!

Uh oh!

		flutterEngine.getPlugins().add(new TestPlugin());
		flutterEngine.getPlugins().add(new IntegrationTestPlugin());

Manual roll Flutter from 911aa7547ed7 to 043b71954ce7 #8693

Manual roll Flutter from 911aa7547ed7 to 043b71954ce7 #8693

Uh oh!

Conversation

stuartmorgan-g commented Feb 24, 2025

Uh oh!

flutter-dashboard bot commented Feb 24, 2025

Uh oh!

reidbaker Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

reidbaker Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

reidbaker Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Feb 24, 2025

Uh oh!

stuartmorgan-g commented Feb 25, 2025

Uh oh!

matanlurey commented Feb 25, 2025

Uh oh!

stuartmorgan-g commented Feb 25, 2025

Uh oh!

reidbaker commented Feb 25, 2025

Uh oh!

stuartmorgan-g commented Feb 25, 2025

Uh oh!

stuartmorgan-g commented Feb 27, 2025

Uh oh!

Uh oh!

Uh oh!