-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[go_router_builder] Proposal: add json support, custom string encoder/decoder #8665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NearTox
wants to merge
2
commits into
flutter:main
Choose a base branch
from
NearTox:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+955
−37
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
// Copyright 2013 The Flutter Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
|
||
import 'package:meta/meta_meta.dart'; | ||
|
||
/// annotation to define a custom parameter decoder/encoder | ||
/// this is useful when the is encoded/decoded in a non-standard way like base64 | ||
/// this must be used as an annotation on a field | ||
/// ```dart | ||
/// String fromBase64(String value) { | ||
/// return const Utf8Decoder().convert(base64.decode(value)); | ||
/// } | ||
/// String toBase64(String value) { | ||
/// return base64.encode(const Utf8Encoder().convert(value)); | ||
/// } | ||
/// class MyRoute { | ||
/// @CustomParameterCodec( | ||
/// encode: toBase64, | ||
/// decode: fromBase64, | ||
/// ) | ||
/// final String data; | ||
/// MyRoute(this.data); | ||
/// } | ||
/// ``` | ||
@Target({TargetKind.field}) | ||
class CustomParameterCodec { | ||
/// create a custom parameter codec | ||
/// | ||
const CustomParameterCodec({ | ||
required this.encode, | ||
required this.decode, | ||
}); | ||
|
||
/// custom function to encode the field | ||
final String Function(String json) encode; | ||
|
||
/// custom function to decode the field | ||
final String Function(String json) decode; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
// Copyright 2013 The Flutter Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
|
||
// ignore_for_file: public_member_api_docs, unreachable_from_main | ||
|
||
import 'dart:convert'; | ||
|
||
import 'package:flutter/material.dart'; | ||
import 'package:go_router/go_router.dart'; | ||
|
||
import 'shared/data.dart'; | ||
|
||
part 'json_example.g.dart'; | ||
|
||
void main() => runApp(App()); | ||
|
||
class App extends StatelessWidget { | ||
App({super.key}); | ||
|
||
@override | ||
Widget build(BuildContext context) => MaterialApp.router( | ||
routerConfig: _router, | ||
title: _appTitle, | ||
); | ||
|
||
final GoRouter _router = GoRouter(routes: $appRoutes); | ||
} | ||
|
||
@TypedGoRoute<HomeRoute>( | ||
path: '/', | ||
name: 'Home', | ||
routes: <TypedGoRoute<GoRouteData>>[ | ||
TypedGoRoute<JsonRoute>(path: 'json'), | ||
], | ||
) | ||
class HomeRoute extends GoRouteData with _$HomeRoute { | ||
const HomeRoute(); | ||
|
||
@override | ||
Widget build(BuildContext context, GoRouterState state) => const HomeScreen(); | ||
} | ||
|
||
class JsonRoute extends GoRouteData with _$JsonRoute { | ||
const JsonRoute(this.json); | ||
|
||
final JsonExample json; | ||
|
||
@override | ||
Widget build(BuildContext context, GoRouterState state) => | ||
JsonScreen(json: json); | ||
} | ||
|
||
class HomeScreen extends StatelessWidget { | ||
const HomeScreen({super.key}); | ||
|
||
@override | ||
Widget build(BuildContext context) => Scaffold( | ||
appBar: AppBar(title: const Text(_appTitle)), | ||
body: ListView( | ||
children: <Widget>[ | ||
for (final JsonExample json in jsonData) | ||
ListTile( | ||
title: Text(json.name), | ||
onTap: () => JsonRoute(json).go(context), | ||
) | ||
], | ||
), | ||
); | ||
} | ||
|
||
class JsonScreen extends StatelessWidget { | ||
const JsonScreen({required this.json, super.key}); | ||
final JsonExample json; | ||
|
||
@override | ||
Widget build(BuildContext context) => Scaffold( | ||
appBar: AppBar(title: Text(json.name)), | ||
body: ListView( | ||
key: ValueKey<String>(json.id), | ||
children: <Widget>[ | ||
Text(json.id), | ||
Text(json.name), | ||
], | ||
), | ||
); | ||
} | ||
|
||
const String _appTitle = 'GoRouter Example: builder'; |
79 changes: 79 additions & 0 deletions
79
packages/go_router_builder/example/lib/json_example.g.dart
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's move this to json_example.dart