[webview_flutter_wkwebview] Updates generated pigeon code to ensure the internal wrapper immediately sends constructor calls #8657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
changed the title
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
test-exempt: updating dependency |
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 20, 2025
…o ensure the internal wrapper immediately sends constructor calls (flutter/packages#8657)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 21, 2025
…o ensure the internal wrapper immediately sends constructor calls (flutter/packages#8657)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 21, 2025
flutter/packages@a9b9172...5a721da 2025-02-20 engine-flutter-autoroll@skia.org Roll Flutter from e8f34a9 to 39b4951 (95 revisions) (flutter/packages#8663) 2025-02-20 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Updates generated pigeon code to ensure the internal wrapper immediately sends constructor calls (flutter/packages#8657) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
…he internal wrapper immediately sends constructor calls (flutter#8657) Potential solution to flutter/flutter#162437 As stated in flutter#8656 (comment), I can only reproduce the crash when adding a delay in the async anonymous function. This should ideally prevent that crash by ensuring the send call is made before entering an async method.
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…he internal wrapper immediately sends constructor calls (flutter#8657) Potential solution to flutter/flutter#162437 As stated in flutter#8656 (comment), I can only reproduce the crash when adding a delay in the async anonymous function. This should ideally prevent that crash by ensuring the send call is made before entering an async method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential solution to flutter/flutter#162437
As stated in #8656 (comment), I can only reproduce the crash when adding a delay in the async anonymous function. This should ideally prevent that crash by ensuring the send call is made before entering an async method.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.