[pigeon] disable deprecated e2e tests #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
force-pushed
the
disable-e2e
branch
2 times, most recently
from
b6289cd to
44c050c
Compare
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
gaaclarke
force-pushed
the
disable-e2e
branch
from
44c050c to
be2f574
Compare
stuartmorgan
approved these changes
Feb 16, 2022
packages/pigeon/run_tests.sh
Outdated
| -sdk iphonesimulator \ | ||
| -destination 'platform=iOS Simulator,name=iPhone 8' \ | ||
| test | ||
| # TODO transition to integration_test. e2e has been deprecated and has stopped |
There was a problem hiding this comment.
Please use standard Flutter TODO format:
# TODO(gaaclarke): Transition to [...]
stuartmorgan
pushed a commit
that referenced
this pull request
Oct 31, 2024
* Reintroduce clipBehavior See dnfield/vector_graphics#180 * Use vector_graphics PR, revert before merge * Update pubspec.yaml --------- Co-authored-by: Fabian Klöckner <fabian.kloeckner@brickmakers.de> Co-authored-by: Dan Field <dfield@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter#98555
These tests were hardly used. We've shifted away from them in favor of unit tests on generated code.
No version change: Just a tweak to CI.
No CHANGELOG change: Just a tweak to CI.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.