[video_player] Fixes mechanism to detect identifier in multiline WebVTT captions #8555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrinneal
requested changes
Feb 3, 2025
Gustl22
changed the title
tarrinneal
approved these changes
Feb 6, 2025
|
|
||
| * Updates minimum supported SDK version to Flutter 3.22/Dart 3.4. | ||
| * Fixes mechanism to detect identifier in multiline WebVTT captions. |
Comment on lines
+169
to
+170
| — It will perforate your stomach. | ||
| — You could die. |
There was a problem hiding this comment.
Just copied it from the test above 😅
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 24, 2025
…iline WebVTT captions (flutter/packages#8555)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 24, 2025
flutter/packages@5a721da...5498d4d 2025-02-21 15619084+vashworth@users.noreply.github.com Redistribute iOS plugin owners (flutter/packages#8664) 2025-02-21 git@reb0.org [video_player] Fixes mechanism to detect identifier in multiline WebVTT captions (flutter/packages#8555) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
…TT captions (flutter#8555) In order to play WebVTT captions which include multiple lines the detection must be changed, as captions don't necessarily have an identifier, when they are longer than two lines.
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…TT captions (flutter#8555) In order to play WebVTT captions which include multiple lines the detection must be changed, as captions don't necessarily have an identifier, when they are longer than two lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to play WebVTT captions which include multiple lines the detection must be changed, as captions don't necessarily have an identifier, when they are longer than two lines.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.