-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[camera_android_camerax][video_player_android] Suppresses deprecation of the SurfaceProducer.Callback.onSurfaceDestroyed
method
#8388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SurfaceProducer.Callback
methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this invalidated by #8384?
@matanlurey I believe #8384 only updates I updated the title to specify the method. |
SurfaceProducer.Callback
methodsSurfaceProducer.Callback.onSurfaceDestroyed
method
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
test-exempt: fixes an existing test that is failing in the roll |
…eprecation of the `SurfaceProducer.Callback.onSurfaceDestroyed` method (flutter/packages#8388)
…eprecation of the `SurfaceProducer.Callback.onSurfaceDestroyed` method (flutter/packages#8388)
…eprecation of the `SurfaceProducer.Callback.onSurfaceDestroyed` method (flutter/packages#8388)
flutter/packages@3fc6b7a...6554751 2025-01-09 stanleycocoa@gmail.com [webview_flutter_wkwebview] Add a listener for the canGoBack property change on the iOS platform. (flutter/packages#8203) 2025-01-09 39571861+memishood@users.noreply.github.com [flutter_svg] Implement errorBuilder callback (flutter/packages#8364) 2025-01-08 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds remaining methods for internal wrapper of the iOS native `IMAAdDisplayContainer`. (flutter/packages#8153) 2025-01-08 jhy03261997@gmail.com [go_router_builder] Add a fallback for a not null List or Set param (flutter/packages#8349) 2025-01-08 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from 8495dee to 17025dd (2 revisions) (flutter/packages#8396) 2025-01-08 10687576+bparrishMines@users.noreply.github.com [ci][video_player_android][camera_android_camerax] Manual roll and fix tests (flutter/packages#8391) 2025-01-07 ditman@gmail.com [ci] Run web tests in wasm (unit + integration). (flutter/packages#8111) 2025-01-07 liff@iki.fi [camera_platform_interface] Add API support query for image streaming (flutter/packages#8307) 2025-01-07 10687576+bparrishMines@users.noreply.github.com [camera_android_camerax][video_player_android] Suppresses deprecation of the `SurfaceProducer.Callback.onSurfaceDestroyed` method (flutter/packages#8388) 2025-01-07 jessiewong401@gmail.com Bump Remaining Plugin Example Apps to targetSdkVersion >= 34 and compileSdkVersion >= 34 (flutter/packages#8361) 2025-01-07 matanlurey@users.noreply.github.com Replace `onSurfaceCreated` with `onSurfaceAvailable`. (flutter/packages#8384) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
… of the `SurfaceProducer.Callback.onSurfaceDestroyed` method (flutter#8388) See flutter/flutter#161256 This was causing errors with the Flutter->Packages roller: ``` > Task :camera_android_camerax:compileDebugJavaWithJavac /b/s/w/ir/x/w/packages/packages/camera/camera_android_camerax/android/src/main/java/io/flutter/plugins/camerax/PreviewHostApiImpl.java:92: warning: [removal] onSurfaceDestroyed() in Callback has been deprecated and marked for removal public void onSurfaceDestroyed() { ^ error: warnings found and -Werror specified 1 error 1 warning ```
…x tests (flutter#8391) Manual roll to check that the test warning suppressions will fix roll. I forgot to update the tests in flutter#8388
… of the `SurfaceProducer.Callback.onSurfaceDestroyed` method (flutter#8388) See flutter/flutter#161256 This was causing errors with the Flutter->Packages roller: ``` > Task :camera_android_camerax:compileDebugJavaWithJavac /b/s/w/ir/x/w/packages/packages/camera/camera_android_camerax/android/src/main/java/io/flutter/plugins/camerax/PreviewHostApiImpl.java:92: warning: [removal] onSurfaceDestroyed() in Callback has been deprecated and marked for removal public void onSurfaceDestroyed() { ^ error: warnings found and -Werror specified 1 error 1 warning ```
…x tests (flutter#8391) Manual roll to check that the test warning suppressions will fix roll. I forgot to update the tests in flutter#8388
See flutter/flutter#161256
This was causing errors with the Flutter->Packages roller:
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.