-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[camera_web] Don't require enumerating cameras on web #8362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
The CLA has been signed, I'm marking the google-cla bot comment above as "resolved". |
I am stuck here - I'm not sure how to dive into the tests to see exactly what is failing. Can anyone help me out here? |
2185930
to
8902e10
Compare
@QoLTech You should be able to click on It looks like one of the tests in
|
From triage: @QoLTech Are you still planning on updating this PR to address the test failures discussed above? |
Enumerating available cameras on web requires permission and activates hardware. This PR allows initializing the camera controller without having to enumerate available cameras first.
flutter/flutter#145541
Continues where #6369 left off
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.md
to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].///
).If you need help, consider asking for advice on the #hackers-new channel on [Discord].