Skip to content

Conversation

@bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Dec 16, 2024

Also fixes flutter/flutter#152352

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 26, 2025
@auto-submit auto-submit bot merged commit d6705de into flutter:main Jan 28, 2025
78 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 28, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jan 28, 2025
flutter/packages@258f6dc...02c6fef

2025-01-28 stuartmorgan@google.com Revert "[shared_preferences] Add
shared preferences devtool" (flutter/packages#8515)
2025-01-28 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_wkwebview] Updates the internal wrapper to use
`@ProxyApi` from pigeon (flutter/packages#8311)
2025-01-28 jhy03261997@gmail.com update the `const` in
StatefulShellRouteData generation (flutter/packages#8502)
2025-01-27 pawel.jakubowski@leancode.pl
[video_player_platform_interface] Platform view support
(flutter/packages#8453)
2025-01-27 andrewrkolos@gmail.com [multicast_dns] Rewrite `_readFQDN` to
avoid recursion (flutter/packages#8390)
2025-01-27 stuartmorgan@google.com [shared_preferences] Fix Android type
mismatch regression (flutter/packages#8512)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@bparrishMines bparrishMines deleted the webview_darwin_proxy branch January 28, 2025 19:10
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
auto-submit bot pushed a commit that referenced this pull request Oct 30, 2025
…ft warning (#9810)

Seen when [upgrading to Xcode 26](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8706580056383404657/+/u/Run_package_tests/validate_iOS_and_macOS_podspecs/stdout).

Introduced in #8311.

Fixes flutter/flutter#173744

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: webview_flutter platform-ios platform-macos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[webview_flutter] Contributions require special tooling

2 participants