Skip to content

[shared_preferences] Activate leak testing #8309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ValentinVignal
Copy link
Contributor

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@ValentinVignal
Copy link
Contributor Author

cc @polina-c

@tarrinneal
Copy link
Contributor

@stuartmorgan this will need a test exemption

@@ -28,6 +28,7 @@ flutter:
dependencies:
flutter:
sdk: flutter
leak_tracker_flutter_testing: any
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in the wrong dependency section.

#8365 will enforce this.

@stuartmorgan-g
Copy link
Contributor

test-exempt: is enabling new testing

flutter/cocoon#4145 will fix this class of false positive going forward.

@ValentinVignal
Copy link
Contributor Author

Ooops sorry about that! I was talking to @polina-c and she was suggesting to not activate leak tracking for packages with no disposable classes for now. Hence, I'll close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants