Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Plugin Example Apps to TargetSdkVersion >= 34 #8285

Merged
merged 3 commits into from
Dec 26, 2024
Merged

Bump Plugin Example Apps to TargetSdkVersion >= 34 #8285

merged 3 commits into from
Dec 26, 2024
+31 −31

Conversation

jesswrd
Copy link
Contributor

@jesswrd jesswrd commented Dec 12, 2024 •
edited
Loading

Bumping all plugin example apps to TargetSdkVersion >= 34. These are the remaining plugins example apps that have to be bumped.

Fixes flutter/flutter#152929

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jesswrd jesswrd added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes and removed p: palette_generator p: flutter_markdown platform-android labels Dec 12, 2024
@jesswrd jesswrd force-pushed the i152929-update-compile-target-sdk-ex-apps branch from 5616291 to bc6577a Compare December 19, 2024 00:04
@jesswrd jesswrd changed the title [WIP] Bump Plugin Example Apps to TargetSdkVersion >= 34 Bump Plugin Example Apps to TargetSdkVersion >= 34 Dec 26, 2024
@jesswrd jesswrd marked this pull request as ready for review December 26, 2024 21:45
@matanlurey
Copy link
Contributor

matanlurey commented Dec 26, 2024 •
edited
Loading

Given these are examples and IMO, trivial, I'd say merge this without waiting for individual CODEOWNERS.

@jesswrd jesswrd added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 26, 2024
camsim99
camsim99 approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change LGTM :) but I do have two non-blocking questions:

  1. I noticed the local_auth_android example is not using the flutter.targetSdkVersion yet. Should we add it to make it consistent? From my quick search it does look like this PR would catch all of the other examples using a different targetSdkVersion.
  2. Should we consider bumping the targetSdkVersion of the all packages app to flutter.targetSdkVersion to in order to test against what we actually target in each of the plugins? cc @reidbaker for thoughts

@auto-submit auto-submit bot merged commit 2d5e714 into flutter:main Dec 26, 2024
77 checks passed
@camsim99
Copy link
Contributor

@jesswrd pinging you in case my questions got lost in the merge!

This change LGTM :) but I do have two non-blocking questions:

  1. I noticed the local_auth_android example is not using the flutter.targetSdkVersion yet. Should we add it to make it consistent? From my quick search it does look like this PR would catch all of the other examples using a different targetSdkVersion.
  2. Should we consider bumping the targetSdkVersion of the all packages app to flutter.targetSdkVersion to in order to test against what we actually target in each of the plugins? cc @reidbaker for thoughts

@jesswrd
Copy link
Contributor Author

jesswrd commented Dec 26, 2024

@camsim99 My bad I didn't see your comments. Let me roll it back :)

@camsim99
Copy link
Contributor

@jesswrd wait no need to roll it back! Maybe we can just reopen the issue and we can discuss there? The change LGTM!

@jesswrd
Copy link
Contributor Author

jesswrd commented Dec 26, 2024

Okay sounds good

@jesswrd jesswrd mentioned this pull request Dec 26, 2024
Closed
45 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2025
Merged
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
Roll Packages from eb7358231e43 to 07ae98c5aff9 (29 revisions) (#161174)
dff62dc 
flutter/packages@eb73582...07ae98c

2025-01-06 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.json:json from 20240303 to 20241224 in
/packages/in_app_purchase/in_app_purchase/example/android/app
(flutter/packages#8371)
2025-01-05 32538273+ValentinVignal@users.noreply.github.com
[google_maps_flutter] Activate leak testing (flutter/packages#8368)
2025-01-05 32538273+ValentinVignal@users.noreply.github.com
[flutter_markdown] Fix some memory leaks and activate leak testing
[prod-leak-fix] (flutter/packages#8367)
2025-01-03 36674458+WenHaozhan@users.noreply.github.com [image_picker]
Removes use of PHAsset on IOS 14+ (flutter/packages#8190)
2025-01-03 matanlurey@users.noreply.github.com Delete unused templates
`skeleton` and `app_shared` and release as `5.0.0`.
(flutter/packages#8360)
2025-01-02 stuartmorgan@google.com [tool] Ensure that
leak_tracker_flutter_testing is dev-only (flutter/packages#8365)
2025-01-02 stuartmorgan@google.com [pigeon] Discuss stability in README
(flutter/packages#8366)
2025-01-02 tarrinneal@gmail.com [shared_preferences] Add information
about shared preferences android to docs (flutter/packages#8296)
2024-12-30 mchudy@users.noreply.github.com [camera] Remove OCMock from
permission tests (flutter/packages#8350)
2024-12-29 kevmoo@users.noreply.github.com Drop vector bits from
allowed_unpinned_deps.yaml (flutter/packages#8327)
2024-12-28 32538273+ValentinVignal@users.noreply.github.com [camera] Fix
memory leaks in example and activate leak testing
(flutter/packages#8287)
2024-12-27 10687576+bparrishMines@users.noreply.github.com [pigeon] Adds
platform for imports that aren't support on a platform
(flutter/packages#8338)
2024-12-26 jessiewong401@gmail.com Bump Plugin Example Apps to
TargetSdkVersion >= 34 (flutter/packages#8285)
2024-12-26 matanlurey@users.noreply.github.com Re-create
`templates/app`, add deprecation notices for `app_shared` and
`skeleton`. (flutter/packages#8336)
2024-12-26 jessiewong401@gmail.com Update Gradle Command Test to Only
Accept Gradle Declarative Apply (flutter/packages#8325)
2024-12-24 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.google.guava:guava from 33.3.1-android to
33.4.0-android in /packages/camera/camera_android_camerax/android
(flutter/packages#8331)
2024-12-24 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump camerax_version from 1.3.4 to 1.4.1 in
/packages/camera/camera_android_camerax/android (flutter/packages#8330)
2024-12-24 49699333+dependabot[bot]@users.noreply.github.com [gradle]:
Bump com.google.truth:truth, com.google.code.gson:gson,
com.squareup.okhttp3:okhttp in /packages/espresso/android
(flutter/packages#8089)
2024-12-24 49699333+dependabot[bot]@users.noreply.github.com
[image_picker]: Bump androidx.activity:activity from 1.9.2 to 1.9.3 in
/packages/image_picker/image_picker_android/android
(flutter/packages#7897)
2024-12-23 ditman@gmail.com [ci] Cumulative fixes to reopen the tree.
(flutter/packages#8344)
2024-12-18 magder@google.com Group dependabot updates for some gradle
dependencies (flutter/packages#8100)
2024-12-18 jessiewong401@gmail.com Applied Gradle Plugins Declaratively
All Remaining Example Apps (flutter/packages#8312)
2024-12-18 49699333+dependabot[bot]@users.noreply.github.com
[lifecycle]: Bump androidx.annotation:annotation from 1.7.0 to 1.9.1 in
/packages/flutter_plugin_android_lifecycle/android
(flutter/packages#7974)
2024-12-18 stuartmorgan@google.com [ci] Re-enable macOS sandboxing
(flutter/packages#8293)
2024-12-18 49699333+dependabot[bot]@users.noreply.github.com [espresso]:
Bump com.android.tools.build:gradle from 7.4.1 to 8.7.2 in
/packages/espresso/android (flutter/packages#8013)
2024-12-18 reidbaker@google.com [shared_preferences] Increase minimum
android endorsed version (flutter/packages#8318)
2024-12-17 stuartmorgan@google.com Revert "[shared_preferences] Add
shared preferences devtools" (flutter/packages#8314)
2024-12-16 adson@soraschools.com [shared_preferences] Add shared
preferences devtools (flutter/packages#6749)
2024-12-16 ditman@gmail.com [google_adsense] Add optional init
parameters. (flutter/packages#8297)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camsim99 camsim99 camsim99 approved these changes

@matanlurey matanlurey matanlurey approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

@gmackall gmackall Awaiting requested review from gmackall gmackall is a code owner

@reidbaker reidbaker Awaiting requested review from reidbaker reidbaker is a code owner

@domesticmouse domesticmouse Awaiting requested review from domesticmouse domesticmouse is a code owner

@tarrinneal tarrinneal Awaiting requested review from tarrinneal tarrinneal is a code owner

@stuartmorgan stuartmorgan Awaiting requested review from stuartmorgan stuartmorgan is a code owner

@Hixie Hixie Awaiting requested review from Hixie Hixie is a code owner

@gspencergoog gspencergoog Awaiting requested review from gspencergoog gspencergoog is a code owner

@chunhtai chunhtai Awaiting requested review from chunhtai chunhtai is a code owner

@ditman ditman Awaiting requested review from ditman ditman is a code owner

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: espresso p: extension_google_sign_in_as_googleapis_auth p: file_selector p: flutter_markdown p: flutter_plugin_android_lifecycle p: flutter_svg p: go_router p: google_maps_flutter p: google_sign_in p: image_picker p: in_app_purchase p: palette_generator p: path_provider p: quick_actions p: rfw Remote Flutter Widgets p: shared_preferences p: url_launcher p: video_player p: webview_flutter platform-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Many] Update compile sdk and target sdk in packages example apps to 34 or higher.
3 participants
@jesswrd @matanlurey @camsim99