Skip to content

[two_dimensional_scrollables] Enable multi-cell/single-cell text selection in Simple Table example #8189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 2, 2025

Conversation

Renzo-Olivares
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares commented Nov 26, 2024

This change adds a SegmentedButton to enable different variations of text selection for the example.

  • Multi-cell selection, enables selection across the entire table, allowing you to select across cells.
  • Single-cell selection, enables selection on individual cells, so the selection cannot escape the cell it started in.
  • Disabled, disables selection across the entire table.

Text selection in a table is a common use-case that we should showcase.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@Renzo-Olivares Renzo-Olivares force-pushed the two_dimensional_selection branch 2 times, most recently from 91462ab to 43b9327 Compare January 13, 2025 20:11
@stuartmorgan-g
Copy link
Contributor

From triage: @Renzo-Olivares are you still planning to finish this PR?

@Renzo-Olivares
Copy link
Contributor Author

I plan on getting back to this soon.

@Piinks
Copy link
Contributor

Piinks commented May 20, 2025

Touched base with @Renzo-Olivares, this is still on his radar. 👍

@Renzo-Olivares Renzo-Olivares force-pushed the two_dimensional_selection branch from 43b9327 to 9e82069 Compare May 28, 2025 18:27
@Renzo-Olivares Renzo-Olivares marked this pull request as ready for review May 28, 2025 19:30
@Renzo-Olivares Renzo-Olivares requested a review from Piinks as a code owner May 28, 2025 19:30
@Renzo-Olivares Renzo-Olivares changed the title Enable multi-cell/single-cell text selection in Simple Table example [two_dimensional_scrollables] Enable multi-cell/single-cell text selection in Simple Table example May 28, 2025
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 2, 2025
@auto-submit auto-submit bot merged commit da1d32f into flutter:main Jun 2, 2025
81 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 3, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jun 3, 2025
flutter/packages@4463066...1765c95

2025-06-03 pawel.jakubowski@leancode.pl [video_player] Platform view
support (flutter/packages#8810)
2025-06-02 kaiquegazola@outlook.com [in_app_purchase_storekit] Add
support to win back offers / promotional offers (flutter/packages#8474)
2025-06-02 rmolivares@renzo-olivares.dev [two_dimensional_scrollables]
Enable multi-cell/single-cell text selection in Simple Table example
(flutter/packages#8189)
2025-05-30 43054281+camsim99@users.noreply.github.com [all_packages]
Bump `compileSdk` version to 35 (flutter/packages#9168)
2025-05-30 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
be698c4 to b25305a (11 revisions) (flutter/packages#9342)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
…ction in Simple Table example (flutter#8189)

This change adds a `SegmentedButton` to enable different variations of text selection for the example.
* Multi-cell selection, enables selection across the entire table, allowing you to select across cells.
* Single-cell selection, enables selection on individual cells, so the selection cannot escape the cell it started in.
* Disabled, disables selection across the entire table.

Text selection in a table is a common use-case that we should showcase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants