-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[two_dimensional_scrollables] Enable multi-cell/single-cell text selection in Simple Table example #8189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 9 commits into
flutter:main
from
Renzo-Olivares:two_dimensional_selection
Jun 2, 2025
Merged
[two_dimensional_scrollables] Enable multi-cell/single-cell text selection in Simple Table example #8189
auto-submit
merged 9 commits into
flutter:main
from
Renzo-Olivares:two_dimensional_selection
Jun 2, 2025
+192
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91462ab
to
43b9327
Compare
From triage: @Renzo-Olivares are you still planning to finish this PR? |
I plan on getting back to this soon. |
Touched base with @Renzo-Olivares, this is still on his radar. 👍 |
43b9327
to
9e82069
Compare
Piinks
approved these changes
Jun 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 3, 2025
… text selection in Simple Table example (flutter/packages#8189)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 3, 2025
flutter/packages@4463066...1765c95 2025-06-03 pawel.jakubowski@leancode.pl [video_player] Platform view support (flutter/packages#8810) 2025-06-02 kaiquegazola@outlook.com [in_app_purchase_storekit] Add support to win back offers / promotional offers (flutter/packages#8474) 2025-06-02 rmolivares@renzo-olivares.dev [two_dimensional_scrollables] Enable multi-cell/single-cell text selection in Simple Table example (flutter/packages#8189) 2025-05-30 43054281+camsim99@users.noreply.github.com [all_packages] Bump `compileSdk` version to 35 (flutter/packages#9168) 2025-05-30 engine-flutter-autoroll@skia.org Roll Flutter (stable) from be698c4 to b25305a (11 revisions) (flutter/packages#9342) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…ction in Simple Table example (flutter#8189) This change adds a `SegmentedButton` to enable different variations of text selection for the example. * Multi-cell selection, enables selection across the entire table, allowing you to select across cells. * Single-cell selection, enables selection on individual cells, so the selection cannot escape the cell it started in. * Disabled, disables selection across the entire table. Text selection in a table is a common use-case that we should showcase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a
SegmentedButton
to enable different variations of text selection for the example.Text selection in a table is a common use-case that we should showcase.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.md
to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].///
).