[google_identity_services_web] Migrate all types to JSObject #8053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And cleanup other legacy JS-interop Also update tests so they pass with WebAssembly
kevmoo
changed the title
srujzs
approved these changes
Nov 13, 2024
Contributor
srujzs
left a comment
srujzs
left a comment
There was a problem hiding this comment.
Thanks again for doing this Kevin!
packages/google_identity_services_web/example/integration_test/utils.dart
Outdated
Show resolved
Hide resolved
packages/google_identity_services_web/example/integration_test/utils.dart
Outdated
Show resolved
Hide resolved
packages/google_identity_services_web/example/integration_test/utils.dart
Outdated
Show resolved
Hide resolved
Contributor
Author
|
We have dart functions in these types...that probably should be JSFunction, right? |
Contributor
Can you share an example of what you're referring to? |
Member
|
Which reminds me that we need to run our web integration tests with |
kevmoo
commented
Nov 16, 2024
| ## 0.3.3 | ||
|
|
||
| * Move all the JavaScript types to extend `JSObject`. | ||
| * Migrates all the JavaScript types to the latest syntax. |
Contributor
Author
There was a problem hiding this comment.
Yeah, but that doesn't tell the user WHAT changed. The fact that these types are now JSObject is the user-visible change.
Member
There was a problem hiding this comment.
Users never see these objects, they don't care about the underlying representation, but let me revert.
auto-submit
bot
removed
the
autosubmit
11 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 18, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 18, 2024
flutter/packages@b164be3...c1eabf5 2024-11-16 49699333+dependabot[bot]@users.noreply.github.com [gradle]: Bump org.mockito.kotlin:mockito-kotlin from 4.1.0 to 5.4.0 in /packages/interactive_media_ads/android (flutter/packages#8095) 2024-11-16 kevmoo@users.noreply.github.com [google_identity_services_web] Migrate all types to JSObject (flutter/packages#8053) 2024-11-15 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump androidx.annotation:annotation from 1.9.0 to 1.9.1 in /packages/file_selector/file_selector_android/android (flutter/packages#7982) 2024-11-15 ditman@gmail.com [web_benchmarks] Remove `WebRenderer` enum. (flutter/packages#8103) 2024-11-15 kevmoo@users.noreply.github.com [google_maps_flutter] Fix detection of WebAssembly compatibility (flutter/packages#8102) 2024-11-15 engine-flutter-autoroll@skia.org Roll Flutter from ed553d1 to 0e2d55e (40 revisions) (flutter/packages#8106) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And cleanup other legacy JS-interop
Also update tests so they pass with WebAssembly