[pigeon] fix int bug

[tarrinneal]

fixes flutter/flutter#155512

[stuartmorgan-g]

LGTM.

Did you audit the other generators to make sure none of them have this same bug in the other direction (for calling a FlutterApi with an int, and no custom types anywhere)?

[tarrinneal]

LGTM.

Did you audit the other generators to make sure none of them have this same bug in the other direction (for calling a FlutterApi with an int, and no custom types anywhere)?

Yeah, the change to handling ints is only a dart change so the logic doesn't exist in the other generators

[EchoEllet]

It seem that this part causing Flutter analysis failure:

class _PigeonCodec extends StandardMessageCodec {
  const _PigeonCodec();
  @override
  void writeValue(WriteBuffer buffer, Object? value) {
    if (value is int) {
      buffer.putUint8(4);
      buffer.putInt64(value); // Unnecessary duplication of receiver. Try using a cascade to avoid the duplication
    } else {
      super.writeValue(buffer, value);
    }
  }

Should be updated to:

buffer..putUint8(4)
      ..putInt64(value);

This version was released as a minor version, pub always uses the latest available minor version and it causes analysis failure, maybe this should be changed to satisfy Dart analysis or ignore all lint rules in the top of the file, or maybe provide the option to?

Since at the moment, we can't directly depend on dart run pigeon --input ./pigeons/messages.dart, instead we have to use our own command which runs dart fix for that generated file to fix them all.

[stuartmorgan-g]

Should be updated to

This PR has already landed, and cannot be updated. The place to report issues with code that has already landed is the issue tracker.

it causes analysis failure [...] maybe this should be changed to satisfy Dart analysis

That depends on your project's analysis settings; Dart has many optional analysis options, some of which are contradictory. We do not (and cannot, due to the contradictory settings) guarantee that all Pigeon-generated code will pass every possible set of analysis options.

or ignore all lint rules in the top of the file, or maybe provide the option to?

You can put arbitrary text in the copyrightHeader file, including ignore options.

[EchoEllet]

That depends on your project's analysis settings; Dart has many optional analysis options, some of which are contradictory. We do not (and cannot, due to the contradictory settings) guarantee that all Pigeon-generated code will pass every possible set of analysis options.

You're right, it seems that I have missed that the cascade_invocations is not part of the recommended nor the core lints provided by lints and flutter_lints.

So an issue specific to a project and not part of this repo.

Thank you for clarifying.