Skip to content

[local_auth] Update Pigeon in iOS and Android #7724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented Sep 27, 2024

Updates local_auth_android and local_auth_darwin to the latest version of Pigeon, allowing removal of the workarounds for:

  • lack of enum support in collections (no need for a wrapper class now)
  • non-nullable collection generics (no need for force-unwrapping in Dart).

Part of flutter/flutter#133455
Part of flutter/flutter#155891

Pre-launch Checklist

Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android LGTM!

Copy link
Contributor

@LouiseHsu LouiseHsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS lgtm!

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 1, 2024
@auto-submit auto-submit bot merged commit 80f442e into flutter:main Oct 1, 2024
76 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 2, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 2, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 2, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 2, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 2, 2024
flutter/packages@ebcc4f0...7c97c88

2024-10-02 stuartmorgan@google.com [file_selector] Convert Linux to Pigeon (flutter/packages#7770)
2024-10-02 matanlurey@users.noreply.github.com Background/resuming `video_player` on Android sends one `initialized` event (flutter/packages#7722)
2024-10-02 43054281+camsim99@users.noreply.github.com [quick_actions_android] Update instructions for using a launcher activity with more breadcrumbs (flutter/packages#7716)
2024-10-01 43759233+kenzieschmoll@users.noreply.github.com Add flutter frame timings to benchmark metrics (flutter/packages#7759)
2024-10-01 stuartmorgan@google.com [local_auth] Update Pigeon in iOS and Android (flutter/packages#7724)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants