Skip to content

[url_launcher] Ignore new unreachable_switch_default warning. #7487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2024
Merged

[url_launcher] Ignore new unreachable_switch_default warning. #7487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/url_launcher/url_launcher_android/lib/url_launcher_android.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ class UrlLauncherAndroid extends UrlLauncherPlatform {
case PreferredLaunchMode.platformDefault:
// Intentionally treat any new values as platformDefault; see comment in
// supportsMode.
// ignore: no_default_cases
// ignore: no_default_cases, unreachable_switch_default
default:
// By default, open web URLs in the application.
inApp = url.startsWith('http:') || url.startsWith('https:');
Expand Down
4 changes: 2 additions & 2 deletions packages/url_launcher/url_launcher_ios/lib/url_launcher_ios.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ class UrlLauncherIOS extends UrlLauncherPlatform {
// Intentionally treat any new values as platformDefault; support for any
// new mode requires intentional opt-in, otherwise falling back is the
// documented behavior.
// ignore: no_default_cases
// ignore: no_default_cases, unreachable_switch_default
default:
// By default, open web URLs in the application.
inApp = url.startsWith('http:') || url.startsWith('https:');
Expand Down Expand Up @@ -110,7 +110,7 @@ class UrlLauncherIOS extends UrlLauncherPlatform {
// Default is a desired behavior here since support for new modes is
// always opt-in, and the enum lives in a different package, so silently
// adding "false" for new values is the correct behavior.
// ignore: no_default_cases
// ignore: no_default_cases, unreachable_switch_default
default:
return false;
}
Expand Down