Skip to content

[flutter_adaptive_scaffold] Map NavigationsRails destinations and use group and labelType #7310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 8, 2024

Conversation

martijn00
Copy link
Contributor

@martijn00 martijn00 commented Aug 5, 2024

List which issues are fixed by this PR. You must list at least one issue.

flutter/flutter#141060
flutter/flutter#115235

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@martijn00 martijn00 requested a review from gspencergoog as a code owner August 5, 2024 14:56
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@martijn00 martijn00 force-pushed the expose-rail branch 4 times, most recently from ab050bd to 2489ba1 Compare August 7, 2024 09:04
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@martijn00
Copy link
Contributor Author

@Renzo-Olivares @gspencergoog Done

Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution and the quick changes!

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2024
@gspencergoog
Copy link
Contributor

Looks like there are some changes needed to the CHANGELOG:

 ERROR: Package validation found the following potential issue:
 * /b/s/w/ir/x/w/packages/packages/flutter_adaptive_scaffold/CHANGELOG.md doesn't mention current version (0.1.11+2).
   Consider updating it with notes on this version prior to publication.
 Package validation found the following hint:
 * The previous version is 0.1.11+1.
   
   It seems you are not publishing an incremental update.
   
 ERROR:   Consider one of:
   * 1.0.0 for a first major release.
   * 0.2.0 for a breaking release.
   * 0.1.12 for a minor release.

Copy link
Contributor

auto-submit bot commented Aug 8, 2024

auto label is removed for flutter/packages/7310, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2024
@martijn00
Copy link
Contributor Author

@gspencergoog changelog and version are done now.

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2024
@auto-submit auto-submit bot merged commit 2c49369 into flutter:main Aug 8, 2024
76 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 9, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 9, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 9, 2024
flutter/packages@bb797b9...f7b1256

2024-08-09 engine-flutter-autoroll@skia.org Manual roll Flutter from b6cd31e to 76107bd (14 revisions) (flutter/packages#7349)
2024-08-09 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds support for all `AdEventType`s and ad data (flutter/packages#7287)
2024-08-08 jonahwilliams@google.com [google_maps] remove Impeller opt out. (flutter/packages#7346)
2024-08-08 mhvdijk@gmail.com [flutter_adaptive_scaffold] Map NavigationsRails destinations and use group and labelType (flutter/packages#7310)
2024-08-08 engine-flutter-autoroll@skia.org Manual roll Flutter from d595e98 to b6cd31e (21 revisions) (flutter/packages#7339)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33 pushed a commit to DBowen33/flutter that referenced this pull request Aug 16, 2024
flutter/packages@bb797b9...f7b1256

2024-08-09 engine-flutter-autoroll@skia.org Manual roll Flutter from b6cd31e to 76107bd (14 revisions) (flutter/packages#7349)
2024-08-09 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds support for all `AdEventType`s and ad data (flutter/packages#7287)
2024-08-08 jonahwilliams@google.com [google_maps] remove Impeller opt out. (flutter/packages#7346)
2024-08-08 mhvdijk@gmail.com [flutter_adaptive_scaffold] Map NavigationsRails destinations and use group and labelType (flutter/packages#7310)
2024-08-08 engine-flutter-autoroll@skia.org Manual roll Flutter from d595e98 to b6cd31e (21 revisions) (flutter/packages#7339)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
flutter/packages@bb797b9...f7b1256

2024-08-09 engine-flutter-autoroll@skia.org Manual roll Flutter from b6cd31e to 76107bd (14 revisions) (flutter/packages#7349)
2024-08-09 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds support for all `AdEventType`s and ad data (flutter/packages#7287)
2024-08-08 jonahwilliams@google.com [google_maps] remove Impeller opt out. (flutter/packages#7346)
2024-08-08 mhvdijk@gmail.com [flutter_adaptive_scaffold] Map NavigationsRails destinations and use group and labelType (flutter/packages#7310)
2024-08-08 engine-flutter-autoroll@skia.org Manual roll Flutter from d595e98 to b6cd31e (21 revisions) (flutter/packages#7339)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: flutter_adaptive_scaffold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants