-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[flutter_adaptive_scaffold] Map NavigationsRails destinations and use group and labelType #7310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
ab050bd
to
2489ba1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/flutter_adaptive_scaffold/lib/src/adaptive_scaffold.dart
Outdated
Show resolved
Hide resolved
packages/flutter_adaptive_scaffold/lib/src/adaptive_scaffold.dart
Outdated
Show resolved
Hide resolved
packages/flutter_adaptive_scaffold/test/adaptive_scaffold_test.dart
Outdated
Show resolved
Hide resolved
packages/flutter_adaptive_scaffold/test/adaptive_scaffold_test.dart
Outdated
Show resolved
Hide resolved
packages/flutter_adaptive_scaffold/test/adaptive_scaffold_test.dart
Outdated
Show resolved
Hide resolved
packages/flutter_adaptive_scaffold/lib/src/adaptive_scaffold.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for the contribution and the quick changes!
Looks like there are some changes needed to the CHANGELOG:
|
auto label is removed for flutter/packages/7310, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
@gspencergoog changelog and version are done now. |
… and use group and labelType (flutter/packages#7310)
… and use group and labelType (flutter/packages#7310)
flutter/packages@bb797b9...f7b1256 2024-08-09 engine-flutter-autoroll@skia.org Manual roll Flutter from b6cd31e to 76107bd (14 revisions) (flutter/packages#7349) 2024-08-09 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds support for all `AdEventType`s and ad data (flutter/packages#7287) 2024-08-08 jonahwilliams@google.com [google_maps] remove Impeller opt out. (flutter/packages#7346) 2024-08-08 mhvdijk@gmail.com [flutter_adaptive_scaffold] Map NavigationsRails destinations and use group and labelType (flutter/packages#7310) 2024-08-08 engine-flutter-autoroll@skia.org Manual roll Flutter from d595e98 to b6cd31e (21 revisions) (flutter/packages#7339) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@bb797b9...f7b1256 2024-08-09 engine-flutter-autoroll@skia.org Manual roll Flutter from b6cd31e to 76107bd (14 revisions) (flutter/packages#7349) 2024-08-09 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds support for all `AdEventType`s and ad data (flutter/packages#7287) 2024-08-08 jonahwilliams@google.com [google_maps] remove Impeller opt out. (flutter/packages#7346) 2024-08-08 mhvdijk@gmail.com [flutter_adaptive_scaffold] Map NavigationsRails destinations and use group and labelType (flutter/packages#7310) 2024-08-08 engine-flutter-autoroll@skia.org Manual roll Flutter from d595e98 to b6cd31e (21 revisions) (flutter/packages#7339) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@bb797b9...f7b1256 2024-08-09 engine-flutter-autoroll@skia.org Manual roll Flutter from b6cd31e to 76107bd (14 revisions) (flutter/packages#7349) 2024-08-09 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds support for all `AdEventType`s and ad data (flutter/packages#7287) 2024-08-08 jonahwilliams@google.com [google_maps] remove Impeller opt out. (flutter/packages#7346) 2024-08-08 mhvdijk@gmail.com [flutter_adaptive_scaffold] Map NavigationsRails destinations and use group and labelType (flutter/packages#7310) 2024-08-08 engine-flutter-autoroll@skia.org Manual roll Flutter from d595e98 to b6cd31e (21 revisions) (flutter/packages#7339) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#141060
flutter/flutter#115235
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.