Skip to content

[rfw][ci] Skip failing rfw golden tests #7170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

LouiseHsu
Copy link
Contributor

See flutter/flutter#151995

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@LouiseHsu LouiseHsu requested a review from Hixie as a code owner July 18, 2024 20:43
@github-actions github-actions bot added the p: rfw Remote Flutter Widgets label Jul 18, 2024
@LouiseHsu LouiseHsu requested a review from stuartmorgan-g July 18, 2024 21:20
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LouiseHsu LouiseHsu merged commit 68b6a68 into flutter:main Jul 18, 2024
76 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 19, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 19, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 19, 2024
flutter/packages@c7f0526...3144ac0

2024-07-19 louisehsu@google.com [in_app_purchase_storekit] Migrate FIATransactionCacheTests.m to.Swift (flutter/packages#7172)
2024-07-18 louisehsu@google.com [rfw][ci] Skip failing rfw golden tests (flutter/packages#7170)
2024-07-18 53230888+se09deluca@users.noreply.github.com [go_router] docs: fix flutter run command for Stateful Nested Navigation (flutter/packages#7158)
2024-07-18 louisehsu@google.com [in_app_purchase_storekit] Migrate FIAPPaymentQueueDeleteTests.m to.Swift (flutter/packages#7171)
2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.7.2 to 1.8.2 in /packages/image_picker/image_picker_android/android (flutter/packages#5704)
2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.core:core from 1.10.1 to 1.13.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#6668)
2024-07-18 tarrinneal@gmail.com [shared_preferences] Platform interface for new shared preferences async (flutter/packages#6962)
2024-07-18 reidbaker@google.com [file_selector_android] Use Espresso 4.0 (flutter/packages#7159)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
flutter/packages@c7f0526...3144ac0

2024-07-19 louisehsu@google.com [in_app_purchase_storekit] Migrate FIATransactionCacheTests.m to.Swift (flutter/packages#7172)
2024-07-18 louisehsu@google.com [rfw][ci] Skip failing rfw golden tests (flutter/packages#7170)
2024-07-18 53230888+se09deluca@users.noreply.github.com [go_router] docs: fix flutter run command for Stateful Nested Navigation (flutter/packages#7158)
2024-07-18 louisehsu@google.com [in_app_purchase_storekit] Migrate FIAPPaymentQueueDeleteTests.m to.Swift (flutter/packages#7171)
2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.7.2 to 1.8.2 in /packages/image_picker/image_picker_android/android (flutter/packages#5704)
2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.core:core from 1.10.1 to 1.13.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#6668)
2024-07-18 tarrinneal@gmail.com [shared_preferences] Platform interface for new shared preferences async (flutter/packages#6962)
2024-07-18 reidbaker@google.com [file_selector_android] Use Espresso 4.0 (flutter/packages#7159)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
flutter/packages@c7f0526...3144ac0

2024-07-19 louisehsu@google.com [in_app_purchase_storekit] Migrate FIATransactionCacheTests.m to.Swift (flutter/packages#7172)
2024-07-18 louisehsu@google.com [rfw][ci] Skip failing rfw golden tests (flutter/packages#7170)
2024-07-18 53230888+se09deluca@users.noreply.github.com [go_router] docs: fix flutter run command for Stateful Nested Navigation (flutter/packages#7158)
2024-07-18 louisehsu@google.com [in_app_purchase_storekit] Migrate FIAPPaymentQueueDeleteTests.m to.Swift (flutter/packages#7171)
2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.7.2 to 1.8.2 in /packages/image_picker/image_picker_android/android (flutter/packages#5704)
2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.core:core from 1.10.1 to 1.13.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#6668)
2024-07-18 tarrinneal@gmail.com [shared_preferences] Platform interface for new shared preferences async (flutter/packages#6962)
2024-07-18 reidbaker@google.com [file_selector_android] Use Espresso 4.0 (flutter/packages#7159)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: rfw Remote Flutter Widgets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants