[google_maps_flutter] Custom marker size improvements - platform impls #6826

jokerttu · 2024-05-29T09:25:08Z

Platform implementations portion of : #4055

Adds platform handling for new BitmapDescriptor classes AssetMapBitmap and BytesMapBitmap introduced in #6687

Containing only changes to packages

google_maps_flutter_android
google_maps_flutter_ios
google_maps_flutter_web

Follow up PR will hold the app-facing plugin implementations.

Linked issue: flutter/flutter#34657

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Undeprecate BitmapDescriptor.fromAssetImage and BitmapDescriptor.fromBytes * Undeprecates `BitmapDescriptor.fromAssetImage`. * Undeprecates `BitmapDescriptor.fromBytes`. * Fixes issues with deprecation in version 2.7.0. The new formats won't be supported until #6826 lands. Deprecation notices can be re-added after the implementation PRs have landed. Fixes: flutter/flutter#149183

stuartmorgan-g

Mostly this needs a review from @reidbaker since Android is the only platform that didn't have sign-off in the main PR yet, but I did a quick pass over everything as well.

...google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/Convert.java

packages/google_maps_flutter/google_maps_flutter_android/example/pubspec.yaml

...aps_flutter/google_maps_flutter_ios/example/ios14/ios/RunnerTests/ExtractIconFromDataTests.m

stuartmorgan-g · 2024-05-30T11:27:13Z

packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapMarkerController.m

(Long-term we'll need to rework this, as throwing exceptions violates the style guide. But for now since this is the established pattern in this method, restructuring is out of scope.)

packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapMarkerController.m

reidbaker

Android section reviewed.

...google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/Convert.java

...le_maps_flutter_android/android/src/test/java/io/flutter/plugins/googlemaps/ConvertTest.java

...lutter/google_maps_flutter_android/example/integration_test/resources/icon_image_base64.dart

...tter/google_maps_flutter_ios/example/ios14/integration_test/resources/icon_image_base64.dart

jokerttu · 2024-06-03T20:49:38Z

@ditman @reidbaker @stuartmorgan @cbracken
I have addressed the review comments. It should now be ready for recheck.

stuartmorgan-g

LGTM

...google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/Convert.java

...aps_flutter/google_maps_flutter_ios/example/ios14/ios/RunnerTests/ExtractIconFromDataTests.m

packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapMarkerController.m

stuartmorgan-g · 2024-06-04T15:10:21Z

This had initial iOS and Web approval in the main PR, and I've briefly reviewed everything, so this is good to land once the final comments are addressed. Thanks!

jokerttu · 2024-06-04T15:54:36Z

This had initial iOS and Web approval in the main PR, and I've briefly reviewed everything, so this is good to land once the final comments are addressed. Thanks!

Thanks, final comments are now addressed.

auto-submit · 2024-06-04T18:19:14Z

auto label is removed for flutter/packages/6826, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

…orm impls (flutter/packages#6826)

flutter/packages@11e192a...586faa6 2024-06-05 ditman@gmail.com [google_sign_in_web] Update button_tester to use web_only library. (flutter/packages#6868) 2024-06-05 engine-flutter-autoroll@skia.org Roll Flutter from c246ecd to 27e0656 (17 revisions) (flutter/packages#6875) 2024-06-05 15619084+vashworth@users.noreply.github.com [path_provider] Skip verifying sample file on macOS (flutter/packages#6874) 2024-06-05 joonas.kerttula@codemate.com [google_maps_flutter] Custom marker size improvements (flutter/packages#4055) 2024-06-05 uberchilly@gmail.com [rfw] Material slider widget (flutter/packages#6610) 2024-06-04 ditman@gmail.com [ci] Manual roll Flutter to c246ecd (84 revisions) + fixes (flutter/packages#6863) 2024-06-04 molchanovia.dev@gmail.com Correcting the typo of Flutter in projects (flutter/packages#6850) 2024-06-04 joonas.kerttula@codemate.com [google_maps_flutter] Custom marker size improvements - platform impls (flutter/packages#6826) 2024-06-04 lrn@google.com Avoid cumbersome formatter workaround (flutter/packages#6573) 2024-06-04 15619084+vashworth@users.noreply.github.com Clean Xcode project before analyzing and testing (flutter/packages#6842) 2024-06-03 37848204+RobinCombrink@users.noreply.github.com [pigeon] Kotlin/Java method overloading for the `setUp` method (flutter/packages#6843) 2024-06-03 40719830+Alex-Usmanov@users.noreply.github.com [url_launcher] Add support for setting show title on Chrome Custom Tabs (flutter/packages#6097) 2024-06-03 ditman@gmail.com Revert "Roll Flutter from c85fa6a to 7eebe29 (#6836)" (flutter/packages#6860) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

) Undeprecate BitmapDescriptor.fromAssetImage and BitmapDescriptor.fromBytes * Undeprecates `BitmapDescriptor.fromAssetImage`. * Undeprecates `BitmapDescriptor.fromBytes`. * Fixes issues with deprecation in version 2.7.0. The new formats won't be supported until flutter#6826 lands. Deprecation notices can be re-added after the implementation PRs have landed. Fixes: flutter/flutter#149183

Undeprecate BitmapDescriptor.fromAssetImage and BitmapDescriptor.fromBytes * Undeprecates `BitmapDescriptor.fromAssetImage`. * Undeprecates `BitmapDescriptor.fromBytes`. * Fixes issues with deprecation in version 2.7.0. The new formats won't be supported until flutter/packages#6826 lands. Deprecation notices can be re-added after the implementation PRs have landed. Fixes: flutter/flutter#149183

jokerttu requested review from cbracken, ditman and reidbaker as code owners May 29, 2024 09:25

github-actions bot added p: google_maps_flutter platform-android platform-ios platform-web labels May 29, 2024

jokerttu changed the title ~~[google_maps_flutter] Platform implementations for custom marker size~~ [google_maps_flutter] Custom marker size improvements - platform impls May 29, 2024

jokerttu mentioned this pull request May 29, 2024

[google_maps_flutter] Custom marker size improvements #4055

Merged

11 tasks

jokerttu force-pushed the feature/google_maps_flutter_platform_implementations_custom_marker_size_improvements branch from 1ae5234 to 9c0f1d0 Compare May 29, 2024 10:07

stuartmorgan-g mentioned this pull request May 29, 2024

[Google_maps]After change BitmapDescriptor.fromBytes to BitmapDescriptor.bytes app crash flutter/flutter#149183

Closed

jokerttu mentioned this pull request May 29, 2024

[google_maps_flutter] Undeprecate BitmapDescriptor methods #6832

Merged

11 tasks

jokerttu force-pushed the feature/google_maps_flutter_platform_implementations_custom_marker_size_improvements branch from c63d41c to 1aa3f10 Compare May 29, 2024 20:45

stuartmorgan-g requested changes May 30, 2024

View reviewed changes

reidbaker requested changes May 30, 2024

View reviewed changes

jokerttu force-pushed the feature/google_maps_flutter_platform_implementations_custom_marker_size_improvements branch 3 times, most recently from b5b5126 to f53caaa Compare June 3, 2024 20:24

stuartmorgan-g added triage-android Should be looked at in Android triage triage-ios Should be looked at in iOS triage labels Jun 3, 2024

jokerttu force-pushed the feature/google_maps_flutter_platform_implementations_custom_marker_size_improvements branch 2 times, most recently from 64941a9 to a8542ba Compare June 3, 2024 20:45

jokerttu requested review from reidbaker and stuartmorgan-g June 3, 2024 20:46

jokerttu force-pushed the feature/google_maps_flutter_platform_implementations_custom_marker_size_improvements branch from ddc5ddd to 6226b9e Compare June 4, 2024 07:17

stuartmorgan-g approved these changes Jun 4, 2024

View reviewed changes

reidbaker approved these changes Jun 4, 2024

View reviewed changes

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 4, 2024

jokerttu added 5 commits June 4, 2024 21:15

[google_maps_flutter] custom marker size improvements

1f1b85d

[google_maps_flutter_web] fix pubspec section ordering

41cf53f

[google_maps_flutter] code quality improvements

b03cacb

chore: Fix format for convertTest.java

34fe42b

[google_maps_flutter] improve code quality

defaebd

jokerttu force-pushed the feature/google_maps_flutter_platform_implementations_custom_marker_size_improvements branch from ece090f to defaebd Compare June 4, 2024 18:15

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 4, 2024

jokerttu added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 4, 2024

auto-submit bot merged commit dcd8586 into flutter:main Jun 4, 2024

jokerttu deleted the feature/google_maps_flutter_platform_implementations_custom_marker_size_improvements branch June 5, 2024 12:40

engine-flutter-autoroll mentioned this pull request Jun 5, 2024

Roll Packages from 11e192a86db3 to 3885ac2c5c6c (10 revisions) flutter/flutter#149744

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 5, 2024

dcd8586 [google_maps_flutter] Custom marker size improvements - platf…

59c88cf

…orm impls (flutter/packages#6826)

engine-flutter-autoroll mentioned this pull request Jun 5, 2024

Roll Packages from 11e192a86db3 to 67b082d4e89b (11 revisions) flutter/flutter#149751

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 5, 2024

dcd8586 [google_maps_flutter] Custom marker size improvements - platf…

7f694a4

…orm impls (flutter/packages#6826)

engine-flutter-autoroll mentioned this pull request Jun 5, 2024

Roll Packages from 11e192a86db3 to 023210f7bf59 (12 revisions) flutter/flutter#149760

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 5, 2024

dcd8586 [google_maps_flutter] Custom marker size improvements - platf…

613c3a0

…orm impls (flutter/packages#6826)

engine-flutter-autoroll mentioned this pull request Jun 6, 2024

Roll Packages from 11e192a86db3 to 586faa631499 (13 revisions) flutter/flutter#149820

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 6, 2024

dcd8586 [google_maps_flutter] Custom marker size improvements - platf…

dff155f

…orm impls (flutter/packages#6826)

reidbaker mentioned this pull request Jul 2, 2024

i151188 update espresso dependencies v2 reidbaker/packages#6

Closed

11 tasks

[google_maps_flutter] Custom marker size improvements - platform impls #6826

[google_maps_flutter] Custom marker size improvements - platform impls #6826

Uh oh!

Conversation

jokerttu commented May 29, 2024

Pre-launch Checklist

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g May 30, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

reidbaker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jokerttu commented Jun 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g commented Jun 4, 2024

Uh oh!

jokerttu commented Jun 4, 2024

Uh oh!

auto-submit bot commented Jun 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jokerttu commented Jun 3, 2024 •

edited

Loading