[file_selector] Remove OCMock from iOS implementation #6503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To aid in future conversion to Swift, remove the use of OCMock in favor of a protocol and an explicit stub.
Collaborator
Author
|
I was in this code for SPM testing, and there have been some recent discussions around phasing out OCMock (e.g., to make future Swift transitions easier), so I thought I'd do this one quickly. |
jmagman
approved these changes
Apr 11, 2024
packages/file_selector/file_selector_ios/example/ios/RunnerTests/FileSelectorTests.m
Outdated
Show resolved
Hide resolved
Co-authored-by: Jenn Magder <magder@google.com>
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 12, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 12, 2024
flutter/packages@e98839a...78f684c 2024-04-12 engine-flutter-autoroll@skia.org Roll Flutter from 557fbf5 to 53cba24 (11 revisions) (flutter/packages#6509) 2024-04-11 stuartmorgan@google.com [file_selector] Remove OCMock from iOS implementation (flutter/packages#6503) 2024-04-11 ahmedelsaayid@gmail.com Access current location using uri.path to support deep links (flutter/packages#6474) 2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter from 97cd47a to 557fbf5 (22 revisions) (flutter/packages#6502) 2024-04-11 louisehsu@google.com [packages] Set parallelizable to NO to reduce test flakiness in packages project tests (flutter/packages#6471) 2024-04-11 vbuberen@users.noreply.github.com Update multiple packages to depend on versions with iOS privacy manifest included (flutter/packages#6355) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
flutter/packages@e98839a...78f684c 2024-04-12 engine-flutter-autoroll@skia.org Roll Flutter from 557fbf5 to 53cba24 (11 revisions) (flutter/packages#6509) 2024-04-11 stuartmorgan@google.com [file_selector] Remove OCMock from iOS implementation (flutter/packages#6503) 2024-04-11 ahmedelsaayid@gmail.com Access current location using uri.path to support deep links (flutter/packages#6474) 2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter from 97cd47a to 557fbf5 (22 revisions) (flutter/packages#6502) 2024-04-11 louisehsu@google.com [packages] Set parallelizable to NO to reduce test flakiness in packages project tests (flutter/packages#6471) 2024-04-11 vbuberen@users.noreply.github.com Update multiple packages to depend on versions with iOS privacy manifest included (flutter/packages#6355) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
To aid in future conversion to Swift, remove the use of OCMock in favor of a protocol and an explicit stub.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To aid in future conversion to Swift, remove the use of OCMock in favor of a protocol and an explicit stub.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).