Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go_router] Add support for preloading branches of StatefulShellRoute (revised solution) #6467

Merged
merged 20 commits into from
Nov 12, 2024
Merged

[go_router] Add support for preloading branches of StatefulShellRoute (revised solution) #6467

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
d4f2d0d
Added support for branch preloading
tolo Mar 12, 2024
fc00590
Added support for branch preloading
tolo Mar 12, 2024
62b9894
Updated version and CHANGELOG
tolo Apr 5, 2024
126787f
Merge remote-tracking branch 'origin/statefulshellroute-preload-v2' i…
tolo Apr 5, 2024
b0a92bf
Some refinements and some updates from PR feedback.
tolo Jun 3, 2024
eb3db3b
Merged from upstream/main
tolo Jun 3, 2024
c2eb9b1
Improved description of preload property.
tolo Jul 26, 2024
5d93833
Cleanup obsolete branches
tolo Jul 26, 2024
523bf75
Added branch cleanup code and tests (Note: some are disabled due to e…
tolo Aug 15, 2024
ca3e898
Merged from upstream/main
tolo Aug 15, 2024
6e6c39e
Merged from upstream/main
tolo Sep 4, 2024
d27cf3a
Rolled back some changes in custom_stateful_shell_route.dart (using T…
tolo Sep 4, 2024
ea48de0
Small update due to API change in RouteConfiguration.findMatch.
tolo Sep 4, 2024
9d68693
Code style cleanup.
tolo Sep 24, 2024
604744b
Merge remote-tracking branch 'upstream/main' into statefulshellroute-…
tolo Sep 24, 2024
4bed9fd
Merged from upstream/main
tolo Oct 23, 2024
a5f6600
Bumped version and fixed formatting.
tolo Oct 23, 2024
1b85750
Merge branch 'main' into statefulshellroute-preload-v2
chunhtai Nov 7, 2024
6b50167
Merge remote-tracking branch 'upstream/main' into statefulshellroute-…
tolo Nov 9, 2024
2e631cf
Updated code excerpts
tolo Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Code style cleanup.
  • Loading branch information
@tolo
tolo committed Sep 24, 2024
commit 9d68693eaeb4b2197b6f68ba9d5feb67d6f2005c
9 changes: 5 additions & 4 deletions packages/go_router/lib/src/route.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1384,8 +1384,9 @@ class StatefulNavigationShellState extends State<StatefulNavigationShell>
@override
void dispose() {
super.dispose();
_branchState.forEach(
(_, _StatefulShellBranchState branchState) => branchState.dispose());
for (final _StatefulShellBranchState branchState in _branchState.values) {
branchState.dispose();
}
}

@override
Expand All @@ -1405,8 +1406,8 @@ class StatefulNavigationShellState extends State<StatefulNavigationShell>
.map((StatefulShellBranch branch) => _BranchNavigatorProxy(
key: ObjectKey(branch),
branch: branch,
navigatorForBranch: (StatefulShellBranch b) =>
_branchState[b]?.navigator))
navigatorForBranch: (StatefulShellBranch branch) =>
_branchState[branch]?.navigator))
.toList();

return widget.containerBuilder(context, widget, children);
Expand Down