[google_sign_in_ios] Upgrade GoogleSignIn iOS SDK to 7.1 #6404

jmagman · 2024-03-26T19:41:23Z

Update GoogleSignIn iOS SDK dependency to 7.1, which supports privacy manifests.
Update "fetch deps step" to run pod repo update every time to avoid missing spec failure. Also added a fetch deps step to the all_packages builds, since those could also use a pod repo update but I didn't want to add more logic to those bash scripts.

     [!] CocoaPods could not find compatible versions for pod "GoogleSignIn":
       In Podfile:
         google_sign_in_ios (from `Flutter/ephemeral/.symlinks/plugins/google_sign_in_ios/darwin`) was resolved to 0.0.1, which depends on
           GoogleSignIn (~> 7.1)
     None of your spec sources contain a spec satisfying the dependency: `GoogleSignIn (~> 7.1)`.

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8752192509749702705/+/u/Run_package_tests/download_Dart_and_iOS_deps/stdout

Looks like the new versions of GTMSessionFetcher and AppAuth don't define modules, so there's an error building it statically:

     [!] The following Swift pods cannot yet be integrated as static libraries:
     The Swift pod `GTMAppAuth` depends upon `GTMSessionFetcher` and `AppAuth`, which do not define modules. To opt into those targets generating module maps (which is necessary to import them from Swift when building as static libraries), you may set `use_modular_headers!` globally in your Podfile, or specify `:modular_headers => true` for particular dependencies.

I filed google/gtm-session-fetcher#384 and openid/AppAuth-iOS#844.

In the meantime, I updated the example apps to use_frameworks!, which would be on for Flutter Swift apps, but not Objective-C ones. We could add something to the tool to detect this case, and suggest use_frameworks! be added?

Even though google_sign_in_ios does not contain Swift files, for some reason, there is a "pod lib lint" warning complaining swift_version isn't set. This seems related to GTMAppAuth dependency constraint that went from an Objective-C-only to Swift pod. So I set swift_version since it's harmless.

- WARN  | swift: The validator used Swift `4.0` by default because no Swift version was specified. To specify a Swift version during validation, add the `swift_versions` attribute in your podspec. Note that usage of a `.swift-version` file is now deprecated.

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8752100979634945505/+/u/Run_package_tests/validate_iOS_and_macOS_podspecs/stdout

Issues

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2024-03-26T19:41:25Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

ditman · 2024-03-30T00:49:43Z

~~Thanks for updating the extension_google_sign... package too. I think these changes need a pubspec/CHANGELOG update, so we publish them to pub.dev, right?~~ Nope, the extension is only updating the iOS code for the example app.

jmagman · 2024-03-30T00:55:30Z

Nope, the extension is only updating the iOS code for the example app.

The repo_checks look happy. I can add a NEXT if you want though.

ditman · 2024-03-30T00:59:23Z

Nope, the extension is only updating the iOS code for the example app.

The repo_checks look happy. I can add a NEXT if you want though.

Nope, no need, I thought that something more significant had changed. If users don't need to know about it, no need to put it in a changelog!

ditman

This LGTM, but @vashworth or @stuartmorgan's reviews are more valuable than mine for sure :)

vashworth · 2024-04-01T14:55:12Z

script/tool/lib/src/fetch_deps_command.dart

        flutterCommand,
-        <String>['precache', '--ios'],
+        <String>['precache', '--${precacheIos ? 'ios' : 'macos'}'],


Although it doesn't seem that any uses of "fetch-deps" does this currently, it is possible for both getBoolArg(platformIOS) and getBoolArg(platformMacOS) to be true. Perhaps would be better to make it a function and pass in the platform for each?

IIRC the tool will accept multiple platforms, in which case this can be:

<String>[ 'precache', if (precacheIOS) '--ios', if (precacheMacOS) '--macos', ],

.ci/targets/ios_build_all_packages.yaml

stuartmorgan · 2024-04-01T15:26:29Z

script/tool/lib/src/fetch_deps_command.dart

@@ -79,22 +80,22 @@ class FetchDepsCommand extends PackageLoopingCommand {
    // `pod install` requires having the platform artifacts precached. See
    // https://github.com/flutter/flutter/blob/fb7a763c640d247d090cbb373e4b3a0459ac171b/packages/flutter_tools/bin/podhelper.rb#L47
    // https://github.com/flutter/flutter/blob/fb7a763c640d247d090cbb373e4b3a0459ac171b/packages/flutter_tools/bin/podhelper.rb#L130
-    if (getBoolArg(platformIOS)) {
-      final int exitCode = await processRunner.runAndStream(
+    final bool precacheIos = getBoolArg(platformIOS);


precacheIOS

https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#capitalize-identifiers-consistent-with-their-spelling

stuartmorgan · 2024-04-01T15:26:57Z

script/tool/lib/src/fetch_deps_command.dart

        flutterCommand,
-        <String>['precache', '--ios'],
+        <String>['precache', '--${precacheIos ? 'ios' : 'macos'}'],


IIRC the tool will accept multiple platforms, in which case this can be:

<String>[ 'precache', if (precacheIOS) '--ios', if (precacheMacOS) '--macos', ],

stuartmorgan

LGTM

And it looks like the module issue was fixed upstream (and published?), so hopefully not many people will hit that.

auto-submit · 2024-04-03T21:34:05Z

auto label is removed for flutter/packages/6404, due to - The status or check suite Mac_arm64 macos_platform_tests master - packages has failed. Please fix the issues identified (or deflake) before re-applying this label.

.ci.yaml

jmagman · 2024-04-04T03:49:40Z

And it looks like the module issue was fixed upstream (and published?), so hopefully not many people will hit that.

Neither published yet...

stuartmorgan · 2024-04-04T11:49:37Z

And it looks like the module issue was fixed upstream (and published?), so hopefully not many people will hit that.

Neither published yet...

Hm, so are we okay with everyone with Obj-C apps being broken and having an error message that doesn't give them the right solution? It seems like maybe we should wait a little longer to see if they get published soon.

jmagman · 2024-04-12T00:13:06Z

Hm, so are we okay with everyone with Obj-C apps being broken and having an error message that doesn't give them the right solution? It seems like maybe we should wait a little longer to see if they get published soon.

AppAuth published its fix https://github.com/openid/AppAuth-iOS/releases/tag/1.7.4
Still waiting on GTMSessionFetcher.

stuartmorgan · 2024-04-16T18:14:07Z

https://github.com/CocoaPods/Specs/blob/df2cd82c7ff09bc5fa92d015a5f0a86c49931ac6/Specs/c/e/3/GTMSessionFetcher/3.4.0/GTMSessionFetcher.podspec.json#L27

🎉

stuartmorgan

Re-runs passed!

stuartmorgan · 2024-04-16T18:40:26Z

packages/google_sign_in/google_sign_in_ios/darwin/google_sign_in_ios.podspec

+
+  # AppAuth is a transitive dependency of GoogleSignIn.
+  # Depend on 1.7.4 or higher, which defines modules.
+  s.dependency 'AppAuth', '~> 1.7.4'


Should we do this for GTMSessionFetcher too?

stuartmorgan · 2024-04-16T18:41:31Z

packages/google_sign_in/google_sign_in_ios/darwin/google_sign_in_ios.podspec

+
+  # AppAuth is a transitive dependency of GoogleSignIn.
+  # Depend on 1.7.4 or higher, which defines modules.
+  s.dependency 'AppAuth', '~> 1.7.4'


I think you just want >= 1.7.4 here. This would, as I understand it, block updates to 1.8.x.

(We shouldn't need to set our own upper bound because we aren't directly calling anything on it, so can't be directly broken by API changes.)

Thanks for catching. Done.

stuartmorgan · 2024-04-16T22:16:46Z

packages/google_sign_in/google_sign_in_ios/darwin/google_sign_in_ios.podspec

+  # Depend on versions which defines modules.
+  s.dependency 'AppAuth', '>= 1.7.4'
+  s.dependency 'GTMSessionFetcher', '>= 3.4.0'
+  s.dependency 'GoogleSignIn', '>= 7.1'


Isn't ~> 7.1 right for this one? We don't want to get 8.x without opting in because we do call its APIs directly.

My brain refuses to retain what ~> does. Done.

For the future: we could consider just never using it, since we all have to look it up every time, and manually do the ranges ourselves. But hopefully in the medium term we won't need podspecs at all.

jmagman · 2024-04-16T22:15:35Z

packages/google_sign_in/google_sign_in_ios/pubspec.yaml

@@ -2,7 +2,7 @@ name: google_sign_in_ios
 description: iOS implementation of the google_sign_in plugin.
 repository: https://github.com/flutter/packages/tree/main/packages/google_sign_in/google_sign_in_ios
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+google_sign_in%22
-version: 5.7.5
+version: 5.7.6


Hm, do you think this should be a minor bump instead @stuartmorgan?

Since this one should be a no-op for clients, bugfix seems fine. I don't feel strongly between the two here.

jmagman · 2024-04-16T22:16:09Z

packages/google_sign_in/google_sign_in_ios/darwin/google_sign_in_ios.podspec

+
+  # AppAuth is a transitive dependency of GoogleSignIn.
+  # Depend on 1.7.4 or higher, which defines modules.
+  s.dependency 'AppAuth', '~> 1.7.4'


jmagman · 2024-04-16T22:16:23Z

packages/google_sign_in/google_sign_in_ios/darwin/google_sign_in_ios.podspec

+
+  # AppAuth is a transitive dependency of GoogleSignIn.
+  # Depend on 1.7.4 or higher, which defines modules.
+  s.dependency 'AppAuth', '~> 1.7.4'


Thanks for catching. Done.

jmagman · 2024-04-16T22:16:45Z

packages/google_sign_in/google_sign_in_ios/example/ios/Runner.xcodeproj/project.pbxproj

+				"${PODS_CONFIGURATION_BUILD_DIR}/AppAuth/AppAuthCore_Privacy.bundle",
+				"${PODS_CONFIGURATION_BUILD_DIR}/GTMAppAuth/GTMAppAuth_Privacy.bundle",
+				"${PODS_CONFIGURATION_BUILD_DIR}/GTMSessionFetcher/GTMSessionFetcher_Core_Privacy.bundle",
+				"${PODS_CONFIGURATION_BUILD_DIR}/GTMSessionFetcher/GTMSessionFetcher_Full_Privacy.bundle",


stuartmorgan

LGTM

stuartmorgan · 2024-04-17T15:51:16Z

Merged to pull in the fix for my OOB maps breakage.

stuartmorgan · 2024-04-17T17:49:06Z

🟢 🎉

…tter/packages#6404)

flutter/packages@d39830e...0e3809d 2024-04-18 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.0 to 3.25.1 (flutter/packages#6562) 2024-04-18 stuartmorgan@google.com [ci] Add Linux desktop support to Linux custom_package_tests (flutter/packages#6551) 2024-04-17 katelovett@google.com [two_dimensional_scrollables] Refactor Spans for common use (flutter/packages#6550) 2024-04-17 reidbaker@google.com [in_app_purchase] Add api to expose country code (flutter/packages#6540) 2024-04-17 stuartmorgan@google.com [camera] Initial iOS Pigeon conversion (flutter/packages#6553) 2024-04-17 reidbaker@google.com [in_app_purchase] Add countryCode implementation to android and storekit (flutter/packages#6556) 2024-04-17 magder@google.com [google_sign_in_ios] Upgrade GoogleSignIn iOS SDK to 7.1 (flutter/packages#6404) 2024-04-17 reidbaker@google.com [in_app_purchase_platform_interface] Adds countryCode API (flutter/packages#6548) 2024-04-17 stuartmorgan@google.com [google_maps_flutter] Update app-facing package iOS requirements (flutter/packages#6552) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ynmain · 2024-05-03T23:08:15Z

@jmagman
Hi.
I'm in trouble.
google_sign_in_ios 5.7.6
I just updated to the latest version
cocoapods cannot be updated due to MLKitVision dependencies.

Can we solve this problem?
firebase/flutterfire#12742 (comment)

stuartmorgan · 2024-05-04T00:13:45Z

@ynmain Please use the issue tracker to submit issues (as indicated in our README), not comments on closed PRs.

The issue you are having is not with google_sign_in; see flutter-ml/google_ml_kit_flutter#612

1. Update GoogleSignIn iOS SDK dependency to [7.1](https://github.com/google/GoogleSignIn-iOS/releases/tag/7.1.0), which supports privacy manifests. 1. Update "fetch deps step" to run `pod repo update` every time to avoid missing spec failure. Also added a fetch deps step to the all_packages builds, since those could also use a `pod repo update` but I didn't want to add more logic to those bash scripts. ``` [!] CocoaPods could not find compatible versions for pod "GoogleSignIn": In Podfile: google_sign_in_ios (from `Flutter/ephemeral/.symlinks/plugins/google_sign_in_ios/darwin`) was resolved to 0.0.1, which depends on GoogleSignIn (~> 7.1) None of your spec sources contain a spec satisfying the dependency: `GoogleSignIn (~> 7.1)`. ``` https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8752192509749702705/+/u/Run_package_tests/download_Dart_and_iOS_deps/stdout 3. Looks like the new versions of [`GTMSessionFetcher`](https://github.com/CocoaPods/Specs/blob/master/Specs/c/e/3/GTMSessionFetcher/3.3.2/GTMSessionFetcher.podspec.json) and [`AppAuth`](https://github.com/CocoaPods/Specs/blob/master/Specs/b/b/9/AppAuth/1.7.3/AppAuth.podspec.json) don't define modules, so there's an error building it statically: ``` [!] The following Swift pods cannot yet be integrated as static libraries: The Swift pod `GTMAppAuth` depends upon `GTMSessionFetcher` and `AppAuth`, which do not define modules. To opt into those targets generating module maps (which is necessary to import them from Swift when building as static libraries), you may set `use_modular_headers!` globally in your Podfile, or specify `:modular_headers => true` for particular dependencies. ``` I filed google/gtm-session-fetcher#384 and openid/AppAuth-iOS#844. In the meantime, I updated the example apps to `use_frameworks!`, which would be on for Flutter Swift apps, but not Objective-C ones. We could add something to the tool to detect this case, and suggest `use_frameworks!` be added? 4. Even though google_sign_in_ios does not contain Swift files, for some reason, there is a "pod lib lint" warning complaining `swift_version` isn't set. This seems related to `GTMAppAuth` dependency constraint that went from an Objective-C-only to Swift pod. So I set `swift_version` since it's harmless. ``` - WARN | swift: The validator used Swift `4.0` by default because no Swift version was specified. To specify a Swift version during validation, add the `swift_versions` attribute in your podspec. Note that usage of a `.swift-version` file is now deprecated. ``` https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8752100979634945505/+/u/Run_package_tests/validate_iOS_and_macOS_podspecs/stdout ## Issues * Fixes flutter/flutter#145777 * Fixes flutter/flutter#145866 * See also flutter/flutter#137140

jmagman self-assigned this Mar 26, 2024

jmagman requested a review from vashworth as a code owner March 26, 2024 19:41

github-actions bot added p: google_sign_in platform-ios platform-macos labels Mar 26, 2024

jmagman marked this pull request as draft March 26, 2024 19:42

github-actions bot added the p: extension_google_sign_in_as_googleapis_auth label Mar 28, 2024

This was referenced Mar 28, 2024

[google_sign_in_ios] Pins GoogleSignIn to 7.0.0 in podspec. #6430

Merged

[google_sign_in_ios] Update iOS SDK to 7.1.0 (was: Failing check_podspecs.) flutter/flutter#145866

Closed

jmagman force-pushed the googlesignin-71 branch from 43b9709 to f0ac029 Compare March 29, 2024 23:54

jmagman marked this pull request as ready for review March 30, 2024 00:43

jmagman requested a review from ditman as a code owner March 30, 2024 00:43

jmagman requested a review from stuartmorgan March 30, 2024 00:43

ditman approved these changes Mar 30, 2024

View reviewed changes

vashworth reviewed Apr 1, 2024

View reviewed changes

stuartmorgan reviewed Apr 1, 2024

View reviewed changes

stuartmorgan approved these changes Apr 3, 2024

View reviewed changes

jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 3, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 3, 2024

jmagman mentioned this pull request Apr 3, 2024

[google_sign_in_ios] Upgrade GoogleSignIn iOS without use_frameworks #6458

Closed

jmagman force-pushed the googlesignin-71 branch from 0b331d6 to 23d082a Compare April 4, 2024 03:38

jmagman commented Apr 4, 2024

View reviewed changes

.ci.yaml Outdated Show resolved Hide resolved

M

7269fbd

jmagman added 3 commits April 4, 2024 16:28

Try removing 'download Dart and iOS deps' steps

780a66e

M

4380911

Swap to Mac_x64

f25e679

jmagman force-pushed the googlesignin-71 branch from 23d082a to f25e679 Compare April 4, 2024 23:28

jmagman requested a review from loic-sharma as a code owner April 4, 2024 23:28

Revert ci changes, Xcode project changes

7413702

github-actions bot removed the p: extension_google_sign_in_as_googleapis_auth label Apr 12, 2024

stuartmorgan reviewed Apr 16, 2024

View reviewed changes

GTMSessionFetcher

012b4fe

stuartmorgan reviewed Apr 16, 2024

View reviewed changes

jmagman commented Apr 16, 2024

View reviewed changes

~>

8d1b19c

stuartmorgan approved these changes Apr 17, 2024

View reviewed changes

Merge branch 'main' into googlesignin-71

2d226e1

jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 17, 2024

auto-submit bot merged commit 663b475 into flutter:main Apr 17, 2024
78 checks passed

jmagman deleted the googlesignin-71 branch April 17, 2024 18:03

Abdeltwab mentioned this pull request Apr 18, 2024

Expected Timeline to release a google_sign_in version that Support Apple App Privacy Manifest ? flutter/flutter#146984

Closed

engine-flutter-autoroll mentioned this pull request Apr 18, 2024

Roll Packages from d39830e40c07 to 0e3809d995b6 (9 revisions) flutter/flutter#146992

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 18, 2024

663b475 [google_sign_in_ios] Upgrade GoogleSignIn iOS SDK to 7.1 (flu…

c134186

…tter/packages#6404)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[google_sign_in_ios] Upgrade GoogleSignIn iOS SDK to 7.1 #6404

[google_sign_in_ios] Upgrade GoogleSignIn iOS SDK to 7.1 #6404

jmagman commented Mar 26, 2024 •

edited

Loading

flutter-dashboard bot commented Mar 26, 2024

ditman commented Mar 30, 2024 •

edited

Loading

jmagman commented Mar 30, 2024

ditman commented Mar 30, 2024

ditman left a comment

vashworth Apr 1, 2024

stuartmorgan Apr 1, 2024

stuartmorgan Apr 1, 2024

stuartmorgan Apr 1, 2024

stuartmorgan left a comment

auto-submit bot commented Apr 3, 2024

jmagman commented Apr 4, 2024

stuartmorgan commented Apr 4, 2024

jmagman commented Apr 12, 2024

stuartmorgan commented Apr 16, 2024

stuartmorgan left a comment

stuartmorgan Apr 16, 2024

jmagman Apr 16, 2024

stuartmorgan Apr 16, 2024 •

edited

Loading

jmagman Apr 16, 2024

stuartmorgan Apr 16, 2024

jmagman Apr 16, 2024

stuartmorgan Apr 17, 2024

jmagman Apr 16, 2024

stuartmorgan Apr 16, 2024

jmagman Apr 16, 2024

jmagman Apr 16, 2024

jmagman Apr 16, 2024

stuartmorgan left a comment

stuartmorgan commented Apr 17, 2024

stuartmorgan commented Apr 17, 2024

ynmain commented May 3, 2024

stuartmorgan commented May 4, 2024 •

edited

Loading

[google_sign_in_ios] Upgrade GoogleSignIn iOS SDK to 7.1 #6404

[google_sign_in_ios] Upgrade GoogleSignIn iOS SDK to 7.1 #6404

Conversation

jmagman commented Mar 26, 2024 • edited Loading

Issues

Pre-launch Checklist

flutter-dashboard bot commented Mar 26, 2024

ditman commented Mar 30, 2024 • edited Loading

jmagman commented Mar 30, 2024

ditman commented Mar 30, 2024

ditman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stuartmorgan left a comment

Choose a reason for hiding this comment

auto-submit bot commented Apr 3, 2024

jmagman commented Apr 4, 2024

stuartmorgan commented Apr 4, 2024

jmagman commented Apr 12, 2024

stuartmorgan commented Apr 16, 2024

stuartmorgan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stuartmorgan Apr 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stuartmorgan left a comment

Choose a reason for hiding this comment

stuartmorgan commented Apr 17, 2024

stuartmorgan commented Apr 17, 2024

ynmain commented May 3, 2024

stuartmorgan commented May 4, 2024 • edited Loading

jmagman commented Mar 26, 2024 •

edited

Loading

ditman commented Mar 30, 2024 •

edited

Loading

stuartmorgan Apr 16, 2024 •

edited

Loading

stuartmorgan commented May 4, 2024 •

edited

Loading