Raise gradle wrapper version of legacy project #6132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
approved these changes
Feb 15, 2024
|
I dont see why updating to 6.7.1 would fix either compileSdkVersion not being set or calling substring on a null. |
|
@reidbaker I found the full error again: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8756540924836675809/+/u/Run_package_tests/build_all_packages_for_Android_-_legacy_version/stdout?format=raw It looks like it is the minimum for The IMA plugin uses Kotlin. |
reidbaker
approved these changes
Feb 16, 2024
bparrishMines
added
the
autosubmit
jason-simmons
added a commit
to jason-simmons/flutter
that referenced
this pull request
Feb 17, 2024
0af905d [flutter_migrate] Implement lineTerminator in the MemoryStdout fake (flutter/packages#6152) f865baf Raise gradle wrapper version of legacy project (flutter/packages#6132) b4d8ad7 Bump github/codeql-action from 3.24.1 to 3.24.3 (flutter/packages#6142) cc34b78 [ci/various] Update for 3.19 stable (flutter/packages#6147) 10a8b76 Roll Flutter (stable) from 4145645 to bae5e49 (1550 revisions) (flutter/packages#6145) a36071b Roll Flutter from a628814 to d7867ca (66 revisions) (flutter/packages#6146)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 17, 2024
0af905d [flutter_migrate] Implement lineTerminator in the MemoryStdout fake (flutter/packages#6152) f865baf Raise gradle wrapper version of legacy project (flutter/packages#6132) b4d8ad7 Bump github/codeql-action from 3.24.1 to 3.24.3 (flutter/packages#6142) cc34b78 [ci/various] Update for 3.19 stable (flutter/packages#6147) 10a8b76 Roll Flutter (stable) from 4145645 to bae5e49 (1550 revisions) (flutter/packages#6145) a36071b Roll Flutter from a628814 to d7867ca (66 revisions) (flutter/packages#6146)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
flutter createfor a new plugin onmaster, this error is printed from the legacy build_all_packages test.It looks like only 6.7.1 is required to work with new plugins, so this is only a minor bump.