-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[camerax] Small fixes to starting/stopping video capture #6068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with only comment being, do we often put issue links in changelogs? If so then carry on, otherwise replace with a description of what is being solved
Ah Reid recommended this for another PR but that's the only time I've done it. I have no prob just writing the fixes out, though, so I can do that :) |
@gmackall I assumed that unbinding |
flutter/packages@29d8cc0...11152d2 2024-02-09 jsharp83@gmail.com [webview_flutter] Add interface for showing javascript dialog message (flutter/packages#4704) 2024-02-09 32931186+erdzan12@users.noreply.github.com [pigeon] Implement Screaming Snake Case Conversion for Kotlin Enum Cases (flutter/packages#5918) 2024-02-09 43054281+camsim99@users.noreply.github.com [camerax] Small fixes to starting/stopping video capture (flutter/packages#6068) 2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter from 8431cae to eb5d0a4 (33 revisions) (flutter/packages#6079) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…eOffset` (#6059) This PR implements `setFocusPoint`, `setExposurePoint`, `setExposureOffset` and makes some small fixes here and there, each of which I have left a comment about for context. Part of flutter/flutter#120468 & flutter/flutter#120467. ~NOTE: Should land after #6068 done :)
Fixes small issues I noticed in starting/stopping video capture while working on #6059, notably:
unawaited
calls toawait
to avoid any racy behavior.camera
info afterVideoCapture
use case is bound to the lifecycle of the plugin'sProcessCameraProvider
to make sure it is up to date.Unbindthis would require potentially more changes than I originally thoughtVideoCapture
use case when video recording stops since it was suggested to lazily load it for performance reasons (open to pushback on this).Fixes flutter/flutter#132499 as this PR removes any remaining
unawaited
calls.Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).