-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[in_app_purchase] Add alternative billing apis for android #6056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 37 commits into
flutter:main
from
reidbaker:i142618-alternitive-billing-api-intro
Feb 12, 2024
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
953338a
Enable alternitive billing only available check, add test and code to…
reidbaker 8ab32cc
Enable alternative billing only during client creation and tests cove…
reidbaker 4d06253
ShowAlternativeBillingDialog android native method added
reidbaker 8d95e87
Add tests for null activity behavior
reidbaker 3878b4f
Remove not needed lines of code
reidbaker e516655
Add showAlternativeBillingOnlyInformationDialog and isAlternativeBill…
reidbaker c8efd99
test showAlternativeBillingOnlyInformationDialog and isAlternativeBil…
reidbaker 3bd6a95
add alternative billing only reporting details implementation and tests
reidbaker 3e77c14
formatting and generated code
reidbaker b77152b
Changelog and version bump added
reidbaker 8cacaef
Formatting
reidbaker d4c4454
Merge branch 'main' into i142618-alternitive-billing-api-intro
reidbaker 2f91615
Update to api 34 (required to test end to end, update dependencies, f…
reidbaker fe7a677
Use 0.3.1 instead of 0+19
reidbaker 95214de
Expose country code as labled button
reidbaker fd506c2
Expose other alternative apis as buttons in their own section
reidbaker 6415bee
formatting
reidbaker 448dd2c
Add test for BillingClientManager alternative billing only
reidbaker 1524fe0
Add platform addition tests
reidbaker 7507f02
Show the dialog result code
reidbaker 2ae9119
Set alternative billing only to true in example app
reidbaker 99b3baf
Speling mistake fix
reidbaker b72cd39
Merge branch 'main' into i142618-alternitive-billing-api-intro
reidbaker 240df4a
revert dependencies since they conflict with integration_test
reidbaker 0723af9
changelog copy change
reidbaker 16ce293
Migrate to enum for alternative billing only and play billing
reidbaker dfbb6b7
java formatting
reidbaker d073552
Include generated code change
reidbaker 8e041af
Use json conversion for sending object over wire
reidbaker fe9d77e
Change button text
reidbaker 31788de
Merge branch 'main' into i142618-alternitive-billing-api-intro
reidbaker 31008fa
billingChoiceMode instead of enableAlternatitveBillingOnly
reidbaker b59c645
billing choice converstion to java
reidbaker 7b6b7a2
Code review feedback, documentation, formatting, spelling
reidbaker b144067
Add alternative billing only reporting details example code
reidbaker 8450aaa
Changlog formatting
reidbaker 9730db3
Merge branch 'main' into i142618-alternitive-billing-api-intro
reidbaker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4 changes: 4 additions & 0 deletions
4
packages/in_app_purchase/in_app_purchase_android/CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an actionable comment, but: Interesting that the billing client builder example they show at the link doesn't call
enablePendingPurchases
. That must be a mistake in their documentation, right? It is documented as required in all circumstanceshttps://developer.android.com/reference/com/android/billingclient/api/BillingClient.Builder#enablePendingPurchases()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I am not sure. Organizationally I think it should be safe to include because if the caller was going to use alternative billing only then there are no pending purchases to enable or if there are all that happens on the callers side since they are providing the billing implementation.