Skip to content

[url_launcher]: Fix a grammar error in the comments of launchUrl method #5919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 22, 2024
Merged

[url_launcher]: Fix a grammar error in the comments of launchUrl method #5919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f15bd7d
fix: typo in the comments of launchUrl method
dshukertjr Jan 18, 2024
eed8532
Update changelog to add the fixd
dshukertjr Jan 18, 2024
fc02620
Fix styling of the changelog
dshukertjr Jan 19, 2024
9a1d445
minor fix
dshukertjr Jan 19, 2024
8144ef7
revert changes on the changelog
dshukertjr Jan 19, 2024
251bb99
Update changelog
dshukertjr Jan 19, 2024
6e719c0
Update version of url_launcher
dshukertjr Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/url_launcher/url_launcher/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
## NEXT
## 6.2.4

* Updates support matrix in README to indicate that iOS 11 is no longer supported.
* Clients on versions of Flutter that still support iOS 11 can continue to use this
package with iOS 11, but will not receive any further updates to the iOS implementation.
* Fixes a grammar error in the comments of `launchUrl` method.

## 6.2.3

Expand Down
2 changes: 1 addition & 1 deletion packages/url_launcher/url_launcher/lib/src/url_launcher_uri.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import 'type_conversion.dart';
/// [package:url_launcher_web](https://pub.dev/packages/url_launcher_web#limitations-on-the-web-platform)
/// for more details.
///
/// Returns true if the URL was launched successful, otherwise either returns
/// Returns true if the URL was launched successfully, otherwise either returns
/// false or throws a [PlatformException] depending on the failure.
Future<bool> launchUrl(
Uri url, {
Expand Down
2 changes: 1 addition & 1 deletion packages/url_launcher/url_launcher/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Flutter plugin for launching a URL. Supports
web, phone, SMS, and email schemes.
repository: https://github.com/flutter/packages/tree/main/packages/url_launcher/url_launcher
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+url_launcher%22
version: 6.2.3
version: 6.2.4

environment:
sdk: ">=3.1.0 <4.0.0"
Expand Down