Skip to content

[video_player] Skip flaky tests in certain circumstances on Android #5872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 11, 2024
Merged

[video_player] Skip flaky tests in certain circumstances on Android #5872

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7a1a2f0
Skip flaky video_player tests in certain circumstances on Android
stuartmorgan-g Jan 11, 2024
56e4f91
Don't break web
stuartmorgan-g Jan 11, 2024
3275177
Add logging to debug
stuartmorgan-g Jan 11, 2024
d0757ca
Relax workaround; remove logging
stuartmorgan-g Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions packages/video_player/video_player/example/integration_test/video_player_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,18 @@ void main() {
await controller.seekTo(tenMillisBeforeEnd);
await controller.play();
await tester.pumpAndSettle(_playDuration);
// Android emulators in our CI have frequent flake where the video
// reports as still playing (usually without having advanced at all
// past the seek position, but sometimes having advanced some); if that
// happens, the thing being tested hasn't even had a chance to happen
// due to CI issues, so just report it as skipped.
// TODO(stuartmorgan): Remove once
// https://github.com/flutter/flutter/issues/141145 is fixed.
if ((!kIsWeb && Platform.isAndroid) && controller.value.isPlaying) {
markTestSkipped(
'Skipping due to https://github.com/flutter/flutter/issues/141145');
return;
}
expect(controller.value.isPlaying, false);
expect(controller.value.position, controller.value.duration);

Expand All @@ -157,6 +169,18 @@ void main() {
controller.value.duration - const Duration(milliseconds: 10));
await controller.play();
await tester.pumpAndSettle(_playDuration);
// Android emulators in our CI have frequent flake where the video
// reports as still playing (usually without having advanced at all
// past the seek position, but sometimes having advanced some); if that
// happens, the thing being tested hasn't even had a chance to happen
// due to CI issues, so just report it as skipped.
// TODO(stuartmorgan): Remove once
// https://github.com/flutter/flutter/issues/141145 is fixed.
if ((!kIsWeb && Platform.isAndroid) && controller.value.isPlaying) {
markTestSkipped(
'Skipping due to https://github.com/flutter/flutter/issues/141145');
return;
}
expect(controller.value.isPlaying, false);
expect(controller.value.position, controller.value.duration);

Expand Down