Skip to content

Updated sample icons image #5725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

Musaddiq625
Copy link

Updated sample icons image
gallery_preview_1.0.0 --> gallery_preview_1.0.1

Old
image

New:
gallery_preview_1 0 1

updated sample icons image
updated icons sample image path with the updated image path
Copy link

google-cla bot commented Dec 20, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@MitchellGoodwin
Copy link

Just to be clear, besides the highlight on "alt" being removed, and the text for arrow_2_circlepath_circle_fill being on one line, are there any other changes my eyes are not picking up?

@Musaddiq625
Copy link
Author

@MitchellGoodwin
thanks for the response
yes, this is the only change

while I was finding the new icon, this was keep irritating me 😑
so I updated it myself 🤷🏻‍♂️😄🤞🏻

@MitchellGoodwin
Copy link

Image LGTM. @stuartmorgan looks like check fails because it needs the "override: no versioning needed" label, because the NEXT label is at the top of the changelog, though it looks like #5312 fixes that. Should this PR wait on #5312? They are somewhat related.

@stuartmorgan-g
Copy link
Contributor

looks like check fails because it needs the "override: no versioning needed" label, because the NEXT label is at the top of the changelog

The check fails because this needs a version change.

@Musaddiq625 in the future, please don't delete the checklist from the PR template; it's there for a reason. The checklist entry about versioning links to the docs that explain that this needs a version change, and why.

@stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g
Copy link
Contributor

@Musaddiq625 Are you still planning on updating this PR to add the version and changelog? See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#version-and-changelog-updates for a link to tooling that will handle the details of doing that update.

@stuartmorgan-g
Copy link
Contributor

Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate to submit a new PR if you have the time to address the review comments. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants