Skip to content

[ci][web] Ignore always_specify_types for JSArray. #5669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2023
Merged

[ci][web] Ignore always_specify_types for JSArray. #5669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/file_selector/file_selector_web/example/integration_test/dom_helper_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,11 @@ void main() {

group('getFiles', () {
final File mockFile1 =
// TODO(srujzs): Remove once typed JSArrays (JSArray<T>) get to `stable`.
// ignore: always_specify_types
File(<Object>['123456'].jsify as JSArray, 'file1.txt');
// TODO(srujzs): Remove once typed JSArrays (JSArray<T>) get to `stable`.
// ignore: always_specify_types
final File mockFile2 = File(<Object>[].jsify as JSArray, 'file2.txt');

testWidgets('works', (_) async {
Expand Down
2 changes: 2 additions & 0 deletions packages/google_identity_services_web/example/integration_test/js_interop_id_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ void main() async {
expectConfigValue('login_uri', 'https://www.example.com/login');
expectConfigValue('native_callback', utils.isAJs('function'));
expectConfigValue('cancel_on_tap_outside', isFalse);
// TODO(srujzs): Remove once typed JSArrays (JSArray<T>) get to `stable`.
// ignore: always_specify_types
expectConfigValue('allowed_parent_origin', isA<JSArray>());
expectConfigValue('prompt_parent_id', 'some_dom_id');
expectConfigValue('nonce', 's0m3_r4ndOM_vALu3');
Expand Down
2 changes: 2 additions & 0 deletions packages/google_identity_services_web/lib/src/js_interop/google_accounts_id.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,8 @@ abstract class IdConfiguration {
JSString? context,
JSString? state_cookie_domain,
JSString? ux_mode,
// TODO(srujzs): Remove once typed JSArrays (JSArray<T>) get to `stable`.
// ignore: always_specify_types
JSArray? allowed_parent_origin,
JSFunction? intermediate_iframe_close_callback,
JSBoolean? itp_support,
Expand Down
4 changes: 4 additions & 0 deletions packages/google_sign_in/google_sign_in_web/lib/src/flexible_size_html_element_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ class _FlexHtmlElementView extends State<FlexHtmlElementView> {

/// The function called whenever an observed resize occurs.
void _onResizeEntries(
// TODO(srujzs): Remove once typed JSArrays (JSArray<T>) get to `stable`.
// ignore: always_specify_types
JSArray resizes,
web.ResizeObserver observer,
) {
Expand All @@ -88,6 +90,8 @@ class _FlexHtmlElementView extends State<FlexHtmlElementView> {
/// When mutations are received, this function attaches a Resize Observer to
/// the first child of the mutation, which will drive
void _onMutationRecords(
// TODO(srujzs): Remove once typed JSArrays (JSArray<T>) get to `stable`.
// ignore: always_specify_types
JSArray mutations,
web.MutationObserver observer,
) {
Expand Down