-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update compileSdkVersion for Android examples #522
Conversation
Flutter master now requires that Android applications use compileSdkVersion 31 in order to build.
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
packages/rfw/CHANGELOG.md
Outdated
@@ -1,7 +1,12 @@ | |||
## NEXT | |||
|
|||
* Updates example compileSdkVersion to 31. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing though: Could you clarify which example app corresponds to which update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I had fixed this double-NEXT locally when I uploaded, but apparently on the wrong branch as part of messing up my local branches :P
This has ballooned quite a bit:
These dependent changes had already been done incrementally in flutter/plugins, but not here, and since the failure is out-of-band we have to fix them all at once now :( |
Closing as obsolete; I've moved the parts of this I still want to do over to #537 |
Flutter master now requires that Android applications use
compileSdkVersion 31 in order to build.
This required updating the Kotlin and gradle versions as well.
And that in turn requires Java 11, which means the outdated
Dockerfile needs to be updated. This updates to use the same
base image (and formatter) that flutter/plugins now uses.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).