Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compileSdkVersion for Android examples #522

Closed
wants to merge 9 commits into from

Conversation

stuartmorgan
Copy link
Contributor

@stuartmorgan stuartmorgan commented Nov 23, 2021

Flutter master now requires that Android applications use
compileSdkVersion 31 in order to build.

This required updating the Kotlin and gradle versions as well.

And that in turn requires Java 11, which means the outdated
Dockerfile needs to be updated. This updates to use the same
base image (and formatter) that flutter/plugins now uses.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Flutter master now requires that Android applications use
compileSdkVersion 31 in order to build.
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@@ -1,7 +1,12 @@
## NEXT

* Updates example compileSdkVersion to 31.
Copy link
Contributor

@camsim99 camsim99 Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing though: Could you clarify which example app corresponds to which update?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I had fixed this double-NEXT locally when I uploaded, but apparently on the wrong branch as part of messing up my local branches :P

@google-cla google-cla bot added the cla: yes label Nov 23, 2021
@stuartmorgan
Copy link
Contributor Author

This has ballooned quite a bit:

  • the compile SDK updated required gradle updates
  • that in turn required a Java update
  • which requires a Dockerfile update
  • which affect web tests, and also clang-format

These dependent changes had already been done incrementally in flutter/plugins, but not here, and since the failure is out-of-band we have to fix them all at once now :(

@stuartmorgan stuartmorgan marked this pull request as draft December 9, 2021 19:55
@godofredoc godofredoc changed the base branch from master to main December 13, 2021 22:19
@stuartmorgan
Copy link
Contributor Author

Closing as obsolete; I've moved the parts of this I still want to do over to #537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants