-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[url_launcher] Add an inAppBrowserView
mode
#5155
Merged
auto-submit
merged 21 commits into
flutter:main
from
stuartmorgan:url-launcher-in-app-browser
Oct 24, 2023
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
7ea59ee
Add new mode and query methods
stuartmorgan 50efebc
Pathify
stuartmorgan d155a01
Add desktop implementations of new methods
stuartmorgan 177207d
App-facing updates
stuartmorgan 49c4594
Implement for Android
stuartmorgan 1334828
Implement iOS
stuartmorgan f70a5ee
Add web support for new methos
stuartmorgan 3cbffcd
Handle new mode in backwards compat call
stuartmorgan 4704684
Version bumps
stuartmorgan 8762abe
Update README
stuartmorgan 1f70e21
Update Android example to test Custom Tab
stuartmorgan ed562cd
Autoformat generated code
stuartmorgan 28f0553
Add query support to example to match README
stuartmorgan 6ceb1fb
Merge branch 'main' into url-launcher-in-app-browser
stuartmorgan 1646161
Revert "Pathify"
stuartmorgan 825df8e
Update platform interface constraints
stuartmorgan e8e2dfc
Merge branch 'main' into url-launcher-in-app-browser
stuartmorgan f89bc12
Update constraints
stuartmorgan 78bcf3e
Adjust example to use browser view for simple case
stuartmorgan d97e911
Fix changelog typo
stuartmorgan 1104b6e
Bump SDK requirements to match latest url_launcher_web
stuartmorgan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add desktop implementations of new methods
- Loading branch information
commit d155a015b74ee0f2033e2128140a3ba46b66fc41
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't add
launchUrl
to the desktop platforms in this PR because they don't currently support any mode switches, so it didn't seem as useful. (Someday I'll update them just so we can deprecatelaunch
.)