Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[path_provider_android] Remove testing of existence of typed external directories #5098

Closed
wants to merge 37 commits into from

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented Oct 9, 2023

Removes the (extremely flaky) testing of the existence of typed external directories because this is not reliable; from my testing, it seems that permissions may be required to write to certain files, and we should prefer not to grant these permissions to the plugin as this may not be desired by a developer using the plugin.

Submitting fix as it was blocking #4820 and thus, will unblock #5105.

Example flaky build: https://ci.chromium.org/ui/p/flutter/builders/try/Linux_android%20android_platform_tests_shard_4%20master/2361/overview
Related issue: dart-lang/sdk#44848

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

camsim99 added 30 commits May 1, 2023 16:46
@stuartmorgan
Copy link
Contributor

it seems that permissions may be required to write to certain files, and we should prefer not to grant these permissions to the plugin as this may not be desired by a developer using the plugin

Could we have them hard-coded into the example app for the integration tests? Having validation that we are returning valid paths is kind of nice.

@camsim99
Copy link
Contributor Author

I can look into it. I'll convert this to a draft for now to (i) investigate and (ii) see if I can land #5105 without this fix.

@camsim99 camsim99 marked this pull request as draft October 10, 2023 21:24
@camsim99
Copy link
Contributor Author

If any fixes are required to run path_provider tests on AVDs running Android 34, I'll do them in #5222

@camsim99 camsim99 closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants