-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[path_provider_android] Remove testing of existence of typed external directories #5098
Conversation
Could we have them hard-coded into the example app for the integration tests? Having validation that we are returning valid paths is kind of nice. |
I can look into it. I'll convert this to a draft for now to (i) investigate and (ii) see if I can land #5105 without this fix. |
If any fixes are required to run |
Removes the (extremely flaky) testing of the existence of typed external directories because this is not reliable; from my testing, it seems that permissions may be required to write to certain files, and we should prefer not to grant these permissions to the plugin as this may not be desired by a developer using the plugin.
Submitting fix as it was blocking #4820 and thus, will unblock #5105.
Example flaky build: https://ci.chromium.org/ui/p/flutter/builders/try/Linux_android%20android_platform_tests_shard_4%20master/2361/overview
Related issue: dart-lang/sdk#44848
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).