-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[google_map_flutter_ios] fix didBeginDraggingMarker typo
#5085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4 changes: 4 additions & 0 deletions
4
packages/google_maps_flutter/google_maps_flutter_ios/CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...aps_flutter_ios/example/ios13/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78 changes: 78 additions & 0 deletions
78
...ogle_maps_flutter/google_maps_flutter_ios/example/ios13/ios/RunnerUITests/RunnerUITests.m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| // Copyright 2013 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| #import <XCTest/XCTest.h> | ||
|
|
||
| static const NSTimeInterval kWaitTime = 60; | ||
|
|
||
| @interface RunnerUITests : XCTestCase | ||
|
|
||
| @end | ||
|
|
||
| @implementation RunnerUITests | ||
|
|
||
| - (void)testMarkerDraggingCallbacks { | ||
| XCUIApplication *application = [[XCUIApplication alloc] init]; | ||
| [application launch]; | ||
| XCUIElement *placeMarkerButton = application.staticTexts[@"Place marker"]; | ||
| if (![placeMarkerButton waitForExistenceWithTimeout:kWaitTime]) { | ||
| NSLog(@"application.debugDescription: %@", application.debugDescription); | ||
stuartmorgan-g marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| XCTFail(@"Failed to find the Place marker button."); | ||
| } | ||
| [placeMarkerButton tap]; | ||
|
|
||
| XCUIElement *Add = application.buttons[@"Add"]; | ||
| if (![Add waitForExistenceWithTimeout:kWaitTime]) { | ||
| NSLog(@"application.debugDescription: %@", application.debugDescription); | ||
| XCTFail(@"Failed to find the Add button."); | ||
| } | ||
| [Add tap]; | ||
|
|
||
| XCUIElement *marker = application.buttons[@"marker_id_1"]; | ||
| if (![marker waitForExistenceWithTimeout:kWaitTime]) { | ||
| NSLog(@"application.debugDescription: %@", application.debugDescription); | ||
| XCTFail(@"Failed to find the marker."); | ||
| } | ||
| [marker tap]; | ||
|
|
||
| XCUIElement *toggleDraggable = application.buttons[@"toggle draggable"]; | ||
| if (![toggleDraggable waitForExistenceWithTimeout:kWaitTime]) { | ||
| NSLog(@"application.debugDescription: %@", application.debugDescription); | ||
| XCTFail(@"Failed to find the toggle draggable."); | ||
| } | ||
| [toggleDraggable tap]; | ||
|
|
||
| // Drag marker to center | ||
| [marker pressForDuration:5 thenDragToElement:application]; | ||
|
|
||
| NSPredicate *predicateDragStart = | ||
| [NSPredicate predicateWithFormat:@"label CONTAINS[c] %@", @"_onMarkerDragStart"]; | ||
| NSPredicate *predicateDrag = | ||
| [NSPredicate predicateWithFormat:@"label CONTAINS[c] %@", @"_onMarkerDrag called"]; | ||
| NSPredicate *predicateDragEnd = | ||
| [NSPredicate predicateWithFormat:@"label CONTAINS[c] %@", @"_onMarkerDragEnd"]; | ||
|
|
||
| XCUIElement *dragStart = [application.staticTexts matchingPredicate:predicateDragStart].element; | ||
| if (![dragStart waitForExistenceWithTimeout:kWaitTime]) { | ||
| NSLog(@"application.debugDescription: %@", application.debugDescription); | ||
| XCTFail(@"Failed to find the _onMarkerDragStart."); | ||
| } | ||
| XCTAssertTrue(dragStart.exists); | ||
|
|
||
| XCUIElement *drag = [application.staticTexts matchingPredicate:predicateDrag].element; | ||
| if (![drag waitForExistenceWithTimeout:kWaitTime]) { | ||
| NSLog(@"application.debugDescription: %@", application.debugDescription); | ||
| XCTFail(@"Failed to find the _onMarkerDrag."); | ||
| } | ||
| XCTAssertTrue(drag.exists); | ||
|
|
||
| XCUIElement *dragEnd = [application.staticTexts matchingPredicate:predicateDragEnd].element; | ||
| if (![dragEnd waitForExistenceWithTimeout:kWaitTime]) { | ||
| NSLog(@"application.debugDescription: %@", application.debugDescription); | ||
| XCTFail(@"Failed to find the _onMarkerDragEnd."); | ||
| } | ||
| XCTAssertTrue(dragEnd.exists); | ||
| } | ||
|
|
||
| @end | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this to import the google maps module.