Skip to content

Auto rerun once for top flaky packages targets #4995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

keyonghan
Copy link
Contributor

@@ -403,6 +404,7 @@ targets:
channel: stable
version_file: flutter_stable.version
package_sharding: "--shardIndex 1 --shardCount 6"
presubmit_max_attempts: "2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a tracking bug?

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not really work as intended; the shards aren't stable since the packages run on a given shard depend on the packages changed in the PR.

Also, the kind of test that is flaking here already has its own internal retry logic. The problem is that a test in this shard (when running all packages) has recently become extremely flaky; we're trying to isolate which one to disable it so that we don't have to turn off the entire plugin's tests. I don't think adding a second (less efficient) layer of retries is a good idea here.

@keyonghan
Copy link
Contributor Author

This will not really work as intended; the shards aren't stable since the packages run on a given shard depend on the packages changed in the PR.

Also, the kind of test that is flaking here already has its own internal retry logic. The problem is that a test in this shard (when running all packages) has recently become extremely flaky; we're trying to isolate which one to disable it so that we don't have to turn off the entire plugin's tests. I don't think adding a second (less efficient) layer of retries is a good idea here.

Proposing this change mainly due to the annoying flake that happens on the dependbot dependency bumping PRs. For example #4988. Infra team has to manually keep rerunning the failed/flaky targets and adding the autosubmit label until they pass.

Is there any bug tracking the fix/skip of the specific flaky tests in these flaky shards?

@stuartmorgan-g
Copy link
Contributor

Is there any bug tracking the fix/skip of the specific flaky tests in these flaky shards?

flutter/flutter#130986 is tracking the current bad flake.

@keyonghan
Copy link
Contributor Author

Closing in favor of the root flake bug.

@keyonghan keyonghan closed this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants