[pigeon] Consolidate mock handler tests #4642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrinneal
reviewed
Aug 3, 2023
| @@ -599,6 +599,7 @@ if (replyList == null) { | |||
| Root root, | |||
| StringSink sink, { | |||
| required String dartPackageName, | |||
There was a problem hiding this comment.
Is this used anywhere now? Could we adjust the argument instead of adding a second param?
There was a problem hiding this comment.
It's still used in all of the channel names that the test implementation listens to. That's what makes this so fun: the channels have to use the user-provided value or the code will fail at runtime, but the import has to use the actual enclosing package, or the code will fail at compile time, and they aren't always the same.
(It's possible that this will only ever actually affect our tests in practice, but it could happen to anyone with an equally niche setup.)
tarrinneal
approved these changes
Aug 4, 2023
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 7, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 7, 2023
flutter/packages@ce53da1...d7ee75a 2023-08-05 stuartmorgan@google.com [tool] Skip pathified analysis on resolver errors (flutter/packages#4647) 2023-08-05 stuartmorgan@google.com [ci] Remove tools from Dockerfile (flutter/packages#4649) 2023-08-05 32242716+ricardoamador@users.noreply.github.com Update to not backfill the ci.yaml roller task. (flutter/packages#4651) 2023-08-04 stuartmorgan@google.com [pigeon] Consolidate mock handler tests (flutter/packages#4642) 2023-08-04 stuartmorgan@google.com [camera_web] Adopt code excerpts in README (flutter/packages#4584) 2023-08-04 stuartmorgan@google.com [image_picker] Allows 3.0 web implementation (flutter/packages#4648) 2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter from c00d241 to 2ba9f7b (25 revisions) (flutter/packages#4646) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates the
mock_handler_testersub-package, which existed just for a single unit test file and required duplicatepigeons/message.dartoutput generation with bespoke test wrappers, folding that test into the shared harness and generation system. This also eliminates an entire test suite from the test harness since it's now part of the rest of the Dart unit testing.This surfaced an edge-case problem with the new package name override, which is that if the override doesn't match the actual dart output location, generated Dart test output won't compile because the import will be wrong. This addresses that by passing the actual package as well to the test generator.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).