[pigeon] Consolidate main Dart unit tests #4641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
added
the
override: no changelog needed
|
No changelog: this is dev-only. |
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 4, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 4, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 4, 2023
flutter/packages@d00c1f9...ce53da1 2023-08-04 ditman@gmail.com [image_picker_web] Listens to file input cancel event. (flutter/packages#4453) 2023-08-04 maurits@vnbskm.nl [in_app_purchase] Updates handling of subscription price changes in README. (flutter/packages#4643) 2023-08-03 stuartmorgan@google.com [pigeon] Consolidate main Dart unit tests (flutter/packages#4641) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates
flutter_null_safe_unit_tests, moving the tests into the same consolidated test plugin that we are using for integration tests. This removes duplicate generation ofpigeons/Dart output, and makes the overall test harness more consistent (e.g., we can now remove some bespoke generation code in the test scripts).(
mock_handler_testsare still separate; that will be left for another PR.)This also removes analysis and Dart unit testing from the set of tests run by
run_tests.dart(the backing for custom-tests in CI) since, as checked-in packages, they are already analyzed and tested by the normal CI steps that do Dart analysis and testing, so that was duplicating CI work. They are still part oftest.dartfor convenience of local testing during Pigeon development.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).