go_router should allow setting requestFocus #4636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannah-hyj
changed the title
chunhtai
reviewed
Aug 4, 2023
| /// Whether or not the navigator and it's new topmost route should request focus | ||
| /// when the new route is pushed onto the navigator. | ||
| /// | ||
| /// Defaults to true. |
There was a problem hiding this comment.
maybe add a link to navigator.requestfocus
| @@ -83,6 +83,7 @@ class GoRouter implements RouterConfig<RouteMatchList> { | |||
| bool debugLogDiagnostics = false, | |||
| GlobalKey<NavigatorState>? navigatorKey, | |||
| String? restorationScopeId, | |||
| bool? requestFocus, | |||
There was a problem hiding this comment.
can you add a doc comment in gorouter describe this parameter
There was a problem hiding this comment.
why is this nullable? I think we can default it to true?
Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
chunhtai
reviewed
Aug 9, 2023
chunhtai
approved these changes
Aug 9, 2023
hannah-hyj
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/packages/4636, due to - The status or check suite android-platform_tests CHANNEL:master PACKAGE_SHARDING:--shardIndex 2 --shardCount 6 has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
hannah-hyj
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 11, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 11, 2023
flutter/packages@881c1f5...9b15c2e 2023-08-10 tarrinneal@gmail.com [dynamic_layouts] relax layout test to fix tree (flutter/packages#4677) 2023-08-10 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.2 to 2.21.3 (flutter/packages#4664) 2023-08-09 jhy03261997@gmail.com go_router should allow setting requestFocus (flutter/packages#4636) 2023-08-09 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android][webview_flutter_wkwebview] Fixes widget rebuild bug caused by key type (flutter/packages#4667) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: flutter/flutter#129581
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.