-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[tooling] mark infra steps as infra steps in yaml files #4473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
69f16f0
58d69c2
a2a11e3
3645835
a9f97ac
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
tasks: | ||
- name: prepare tool | ||
script: .ci/scripts/prepare_tool.sh | ||
infra_step: true # Note infra steps failing prevents "always" from running. | ||
- name: custom tests | ||
script: script/tool_runner.sh | ||
args: ["custom-test"] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,10 @@ | ||
tasks: | ||
- name: prepare tool | ||
script: .ci/scripts/prepare_tool.sh | ||
infra_step: true # Note infra steps failing prevents "always" from running. | ||
- name: create all_packages app | ||
script: .ci/scripts/create_all_packages_app.sh | ||
infra_step: true # Note infra steps failing prevents "always" from running. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this step (same as in other yaml files) belong to infra? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes assuming you are asking about if this step is infrastructure around getting a test to start running. This pr is not trying to transfer any additional responsibility to the infra-team. What is important here is in our tooling if prepare_tool or create all_packages app fails. It is not a test failure but an infra failure. Also it is likely to happen to every test that uses the same script at the same time. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We'll have to see in practice; this could also potentially fail in the roller if the I would lean slightly toward not marking it, but we can always adjust later if it's an issue. |
||
- name: build all_packages for macOS debug | ||
script: .ci/scripts/build_all_packages_app.sh | ||
args: ["macos", "debug"] | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
tasks: | ||
- name: prepare tool | ||
script: .ci/scripts/prepare_tool.sh | ||
infra_step: true # Note infra steps failing prevents "always" from running. | ||
- name: validate iOS and macOS podspecs | ||
script: script/tool_runner.sh | ||
args: ["podspec-check"] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,13 @@ | ||
tasks: | ||
- name: prepare tool | ||
script: .ci/scripts/prepare_tool.sh | ||
infra_step: true # Note infra steps failing prevents "always" from running. | ||
- name: create simulator | ||
script: .ci/scripts/create_simulator.sh | ||
infra_step: true # Note infra steps failing prevents "always" from running. | ||
reidbaker marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- name: custom package tests | ||
script: .ci/scripts/custom_package_tests.sh | ||
- name: remove simulator | ||
script: .ci/scripts/remove_simulator.sh | ||
always: true | ||
infra_step: true |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
tasks: | ||
- name: prepare tool | ||
script: .ci/scripts/prepare_tool.sh | ||
infra_step: true # Note infra steps failing prevents "always" from running. | ||
- name: tool unit tests | ||
script: .ci/scripts/plugin_tools_tests.sh |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
tasks: | ||
- name: prepare tool | ||
script: .ci/scripts/prepare_tool.sh | ||
infra_step: true # Note infra steps failing prevents "always" from running. | ||
- name: Dart unit tests - web | ||
script: script/tool_runner.sh | ||
args: ["dart-test", "--exclude=script/configs/dart_unit_tests_exceptions.yaml", "--platform=chrome"] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
tasks: | ||
- name: prepare tool | ||
script: .ci/scripts/prepare_tool.sh | ||
infra_step: true # Note infra steps failing prevents "always" from running. | ||
- name: custom package tests | ||
script: .ci/scripts/custom_package_tests.sh |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
tasks: | ||
- name: prepare tool | ||
script: .ci/scripts/prepare_tool.sh | ||
infra_step: true # Note infra steps failing prevents "always" from running. | ||
- name: dart unit tests | ||
script: .ci/scripts/dart_unit_tests_win32.sh |
Uh oh!
There was an error while loading. Please reload this page.