-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[web_benchmarks] Migrate custom test to custom_package_tests
#4429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 4 commits into
flutter:main
from
stuartmorgan-g:luci-web-benchmarks-custom-test
Jul 10, 2023
Merged
[web_benchmarks] Migrate custom test to custom_package_tests
#4429
auto-submit
merged 4 commits into
flutter:main
from
stuartmorgan-g:luci-web-benchmarks-custom-test
Jul 10, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
51 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 11, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 11, 2023
flutter/packages@4469c5e...188a846 2023-07-11 32538273+ValentinVignal@users.noreply.github.com [go_router] Fix some typos in the comments and asserts (flutter/packages#4412) 2023-07-11 tarrinneal@gmail.com [pigeon] `Object` type in class integration tests (flutter/packages#4384) 2023-07-11 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.8.22 to 1.9.0 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#4419) 2023-07-10 stuartmorgan@google.com [ci] Add initial LUCI legacy analysis (flutter/packages#4428) 2023-07-10 stuartmorgan@google.com [web_benchmarks] Migrate custom test to `custom_package_tests` (flutter/packages#4429) 2023-07-10 goddchen@gmail.com go_router: docs: fix typo in StatefulShellRoute.indexedStack(...) docs (flutter/packages#4341) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the bespoke CI task for
web_benchmarks
, and sets up a custom test script to drive it, causing it to run in the existingcustom_package_tests
CI task.For now it's Linux-only to preserve the existing behavior; anyone is welcome to enable it for other packages in the future after ensuring it works in those environments.