Skip to content

[web_benchmarks] Migrate custom test to custom_package_tests #4429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stuartmorgan-g
Copy link
Contributor

Removes the bespoke CI task for web_benchmarks, and sets up a custom test script to drive it, causing it to run in the existing custom_package_tests CI task.

For now it's Linux-only to preserve the existing behavior; anyone is welcome to enable it for other packages in the future after ensuring it works in those environments.

Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 10, 2023
@auto-submit auto-submit bot merged commit 82f6fca into flutter:main Jul 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 11, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 11, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 11, 2023
flutter/packages@4469c5e...188a846

2023-07-11 32538273+ValentinVignal@users.noreply.github.com [go_router] Fix some typos in the comments and asserts (flutter/packages#4412)
2023-07-11 tarrinneal@gmail.com [pigeon] `Object` type in class integration tests (flutter/packages#4384)
2023-07-11 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.8.22 to 1.9.0 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#4419)
2023-07-10 stuartmorgan@google.com [ci] Add initial LUCI legacy analysis (flutter/packages#4428)
2023-07-10 stuartmorgan@google.com [web_benchmarks] Migrate custom test to `custom_package_tests` (flutter/packages#4429)
2023-07-10 goddchen@gmail.com go_router: docs: fix typo in StatefulShellRoute.indexedStack(...) docs (flutter/packages#4341)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: web_benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants