[ci] Bring up LUCI Linux custom package tests #4382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
commented
Jul 5, 2023
stuartmorgan-g
force-pushed
the
luci-linux-custom-package
branch
2 times, most recently
from
315e350 to
3c3c314
Compare
stuartmorgan-g
force-pushed
the
luci-linux-custom-package
branch
from
3c3c314 to
7981f40
Compare
ditman
reviewed
Jul 6, 2023
| @@ -214,6 +214,40 @@ targets: | |||
| channel: stable | |||
| version_file: flutter_stable.version | |||
|
|
|||
| - name: Linux_android custom_package_tests master | |||
There was a problem hiding this comment.
Does the name of these need to start with Linux_android? Why not just Linux custom_package_tests master?
There was a problem hiding this comment.
That would use the more generic Linux configuration, and then I would have to duplicate all the dependencies in each of the targets. I considered it, but opted for less repetition over preferred naming.
The rigidity of LUCI .ci.yaml naming and how it determines behavior is definitely not one of my favorite parts of LUCI. I would much rather the base config be a property unrelated to name.
ditman
reviewed
Jul 6, 2023
| version_file: flutter_master.version | ||
| target_file: linux_custom_package_tests.yaml | ||
| cores: "32" | ||
| # Pigeon tests need Andoid deps (thus the Linux_android base) and |
There was a problem hiding this comment.
Suggested change
| # Pigeon tests need Andoid deps (thus the Linux_android base) and | |
| # Pigeon tests need Android deps (thus the Linux_android base) and |
Is this sufficient to name the suite "Linux_android" though? :P
There was a problem hiding this comment.
Linux_andoid custom_package_tests master :P
ditman
reviewed
Jul 6, 2023
tarrinneal
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Approval from me once you and @ditman resolve your differences.
| version_file: flutter_master.version | ||
| target_file: linux_custom_package_tests.yaml | ||
| cores: "32" | ||
| # Pigeon tests need Andoid deps (thus the Linux_android base) and |
tarrinneal
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 6, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 6, 2023
flutter/packages@7042079...771ec9b 2023-07-06 stuartmorgan@google.com [ci] Enable LUCI Dart unit tests (flutter/packages#4378) 2023-07-06 stuartmorgan@google.com [ci] Bring up LUCI Linux custom package tests (flutter/packages#4382) 2023-07-06 tarrinneal@gmail.com [pigeon] adds generate option for example pigeons (flutter/packages#4370) 2023-07-06 47866232+chunhtai@users.noreply.github.com [go_router] Allows redirect only GoRoute to be part of RouteMatchList (flutter/packages#4315) 2023-07-06 49699333+dependabot[bot]@users.noreply.github.com [sign_in]: Bump com.google.android.gms:play-services-auth from 20.5.0 to 20.6.0 in /packages/google_sign_in/google_sign_in_android/android (flutter/packages#4359) 2023-07-06 41930132+hellohuanlin@users.noreply.github.com [pigeon]fix a crash when casting NSNull to an Array (flutter/packages#4289) 2023-07-06 hello@kamil.id [google_sign_in_web] Fixes force unwrap on values that can be null (flutter/packages#4374) 2023-07-05 engine-flutter-autoroll@skia.org Roll Flutter from 590ef2d to 35085c3 (3 revisions) (flutter/packages#4379) 2023-07-05 43054281+camsim99@users.noreply.github.com [camerax] Fixes `unawaited_futures` violations (flutter/packages#4337) 2023-07-05 stuartmorgan@google.com [ci] Remove `starqlteue` from FTL tests (flutter/packages#4375) 2023-07-05 stuartmorgan@google.com [tools] Switch to `flutter test` (flutter/packages#4348) 2023-07-05 joshuapetitma@yahoo.com [flutter_markdown] Add TableCellVerticalAlignment property in markdown stylesheet (flutter/packages#3880) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds LUCI version of Linux custom package tests.
Removes the custom tests for
cross_fileandgoogle_identity_services_websince they only existed to run unit tests in browser mode, which is now standard for all packages that can be run that way.Part of flutter/flutter#114373