Skip to content

Conversation

@bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Jun 30, 2023

For flutter/flutter#127323

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@bparrishMines bparrishMines requested a review from cyanglaz as a code owner June 30, 2023 19:27
@bparrishMines bparrishMines changed the title Webview unawaited [webview_flutter_android][webview_flutter_wkwebview] Fixes unawaited_futures violations Jun 30, 2023
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 6, 2023
@auto-submit auto-submit bot merged commit 56e3b1c into flutter:main Jul 6, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 7, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 7, 2023
flutter/packages@771ec9b...9bcf4bf

2023-07-07 stuartmorgan@google.com [ci] Add LUCI web platform tests (flutter/packages#4391)
2023-07-07 stuartmorgan@google.com [webview_flutter] Enable unawaited_futures lint (flutter/packages#4271)
2023-07-07 stuartmorgan@google.com [ci] Add partial LUCI version of repo_checks (flutter/packages#4389)
2023-07-06 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.1.3 to 2.2.0 (flutter/packages#4302)
2023-07-06 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android][webview_flutter_wkwebview] Fixes unawaited_futures violations (flutter/packages#4354)
2023-07-06 stuartmorgan@google.com [local_auth] Update Windows Pigeon version (flutter/packages#4388)
2023-07-06 77553258+victorsanni@users.noreply.github.com [url_launcher] Remove nested third_party safari checker (flutter/packages#4330)
2023-07-06 stuartmorgan@google.com [ci] Add partial LUCI Android platform tests (flutter/packages#4381)
2023-07-06 stuartmorgan@google.com [ci] Switch `master` Linux custom package tests to LUCI (flutter/packages#4386)
2023-07-06 47866232+chunhtai@users.noreply.github.com [go_router] Exposes package-level privates (flutter/packages#4380)
2023-07-06 stuartmorgan@google.com [file_selector] Update to 1.0 (flutter/packages#4362)
2023-07-06 engine-flutter-autoroll@skia.org Roll Flutter from 35085c3 to bc49cd1 (14 revisions) (flutter/packages#4387)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@bparrishMines bparrishMines deleted the webview_unawaited branch July 7, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: webview_flutter platform-android platform-ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants